-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ts): Publish downleveled TS3.8 types, fix types path #8954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
I think the .npmignore
in packages/gatsby
also needs adjusting. Would you mind taking a look at it? Should be the same change as in the root one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
damn, good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! RE tests, great idea but if we wanna ship this quickly, I suggest we take care of them in a follow-up PR.
Here is the follow-up PR |
size-limit report 📦
|
The downleveled types were not shipped.
The mapping of types to the downleveled types had an incorrect path with the
buildDir
prefix.Before this change the
sentry-react-native
typescript 3.8 test failed on :Todo
After these changes the types are shipped and used but something is off as with the default types I have no type errors inThis was caused by .yalc not linking transitive deps (@sentry/browser -> @sentry/core)sentry-react-native
but with the 3.8 types I have 58 type errors.