Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replay): Adjust development hydration error messages #9922

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Dec 19, 2023

Refine the regex to match fewer errors, seeing some false positives in replays that are not hydration errors.

fixes getsentry/sentry#61943

Refine the regex to match fewer errors, seeing some false positives in replays that are not hydration errors.
@scttcper scttcper requested a review from a team December 19, 2023 21:08
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 75.4 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 66.81 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 60.39 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.42 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.02 KB (0%)
@sentry/browser - Webpack (gzipped) 21.72 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 72.81 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 64.51 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 30.74 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 22.78 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 202.77 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 92.68 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 67.72 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 33.58 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 67.17 KB (+0.06% 🔺)
@sentry/react - Webpack (gzipped) 21.76 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 83.95 KB (+0.05% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.58 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 16.35 KB (0%)

@scttcper scttcper merged commit 2d69912 into develop Dec 19, 2023
88 checks passed
@scttcper scttcper deleted the scttcper/refine-dev-hydration-message branch December 19, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SDK] Refine development hydration breadcrumb regex
2 participants