Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(replay): Adjust development hydration error messages #9922

Merged
merged 1 commit into from
Dec 19, 2023
Merged

fix(replay): Adjust development hydration error messages #9922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/replay/src/coreHandlers/handleBeforeSendEvent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,9 @@ function handleHydrationError(replay: ReplayContainer, event: ErrorEvent): void
// Example https://reactjs.org/docs/error-decoder.html?invariant=423
exceptionValue.match(/reactjs\.org\/docs\/error-decoder\.html\?invariant=(418|419|422|423|425)/) ||
// Development builds of react-dom
// Example Text: content did not match. Server: "A" Client: "B"
exceptionValue.match(/(hydration|content does not match|did not match)/i)
// Error 1: Hydration failed because the initial UI does not match what was rendered on the server.
// Error 2: Text content does not match server-rendered HTML. Warning: Text content did not match.
exceptionValue.match(/(does not match server-rendered HTML|Hydration failed because)/i)
) {
const breadcrumb = createBreadcrumb({
category: 'replay.hydrate-error',
Expand Down
3 changes: 2 additions & 1 deletion packages/replay/test/integration/coreHandlers/handleBeforeSendEvent.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ describe('Integration | coreHandlers | handleBeforeSendEvent', () => {
const addBreadcrumbSpy = jest.spyOn(replay, 'throttledAddEvent');

const error = Error();
error.exception.values[0].value = 'Text content did not match. Server: "A" Client: "B"';
error.exception.values[0].value =
'Text content does not match server-rendered HTML. Warning: Text content did not match.';
handler(error);

expect(addBreadcrumbSpy).toHaveBeenCalledTimes(1);
Expand Down