fix(transport): Fallback to fetch transport if native not available #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
changed the title
krystofwoldrich
commented
Dec 14, 2022
| @@ -41,34 +38,16 @@ export class ReactNativeClient extends BaseClient<ReactNativeClientOptions> { | |||
| * @param options Configuration options for this SDK. | |||
| */ | |||
| public constructor(options: ReactNativeClientOptions) { | |||
| if (!options.transport) { | |||
There was a problem hiding this comment.
option.transport is required and has a fallback in sdk.tsx, so this if statement wasn't working
Android (legacy) Performance metrics 🚀
|
Android (new) Performance metrics 🚀
|
krystofwoldrich
changed the title
iOS (new) Performance metrics 🚀
|
|
This is ready for review. |
marandaneto
reviewed
Dec 20, 2022
| * This is a workaround for now using fetch on RN, this is a known issue in react-native and only generates a warning | ||
| * YellowBox deprecated and replaced with with LogBox in RN 0.63 | ||
| */ | ||
| export function ignoreRequireCycleLogs(): void { |
There was a problem hiding this comment.
I agree with the refactoring here and separating the concerns.
marandaneto
approved these changes
Dec 20, 2022
iOS (legacy) Performance metrics 🚀
|
This is implemented in the init function in sdk.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Fixes the unreachable fallback to the fetch transport.
Simplify client constructor. Make it more readable.
💡 Motivation and Context
Not working fetch transport.
💚 How did you test it?
unit tests
📝 Checklist
🔮 Next steps