-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(transport): Fallback to fetch transport if native not available #2695
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
20a6984
ref(client): Remove dep on BrowserClient
krystofwoldrich 3177853
fix formatting
krystofwoldrich b859da1
ref(client): Simplify client constructor
krystofwoldrich 24c9cdd
ref: move exception to threads for messages
krystofwoldrich e4c64f6
only map stacktrace
krystofwoldrich 3dc1b56
Merge branch 'refactor-client-event-from' into ref-client-constructor
krystofwoldrich eafdd0e
Remove unnecessary transport factory, rename ignore logs
krystofwoldrich 15977d1
Merge branch 'main' into refactor-client-event-from
krystofwoldrich a89878b
Fix imports order
krystofwoldrich 898da27
Add changelog
krystofwoldrich 0f2f8cf
Merge branch '5.0.0' into refactor-client-event-from
krystofwoldrich f5fce5f
Merge branch 'refactor-client-event-from' into ref-client-constructor
krystofwoldrich 61fda35
Fix fetch transport can be reached
krystofwoldrich bffe416
Formatting
krystofwoldrich 3c2a41b
Add test to check message event threads
krystofwoldrich 3cb00a9
Add attach stack trace default true
krystofwoldrich f6aa85d
Merge branch 'refactor-client-event-from' into ref-client-constructor
krystofwoldrich a692278
Add tests and changelog
krystofwoldrich 6364cdc
Add pr id
krystofwoldrich f88bf07
Merge branch '5.0.0' into ref-client-constructor
krystofwoldrich e08e61c
Remove unnecessary stack parser fallback
krystofwoldrich fccee60
Fix unused defaultStackParser import
krystofwoldrich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
/* eslint-disable deprecation/deprecation */ | ||
import { LogBox, YellowBox } from 'react-native'; | ||
|
||
/** | ||
* This is a workaround for now using fetch on RN, this is a known issue in react-native and only generates a warning | ||
* YellowBox deprecated and replaced with with LogBox in RN 0.63 | ||
*/ | ||
export function ignoreRequireCycleLogs(): void { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree with the refactoring here and separating the concerns. |
||
if (LogBox) { | ||
LogBox.ignoreLogs(['Require cycle:']); | ||
} else { | ||
YellowBox.ignoreWarnings(['Require cycle:']); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
option.transport
is required and has a fallback insdk.tsx
, so this if statement wasn't working