-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V6 Release #3851
V6 Release #3851
Conversation
Android (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0677344 | 327.74 ms | 337.14 ms | 9.40 ms |
52a8031+dirty | 311.55 ms | 321.37 ms | 9.82 ms |
22e31b6 | 396.48 ms | 419.64 ms | 23.16 ms |
52c0562 | 453.04 ms | 434.71 ms | -18.33 ms |
0ebca77 | 414.93 ms | 444.49 ms | 29.56 ms |
e73f4ed+dirty | 332.96 ms | 354.33 ms | 21.37 ms |
9433f35 | 347.64 ms | 356.22 ms | 8.58 ms |
148f924 | 492.65 ms | 500.28 ms | 7.63 ms |
457e29f | 398.10 ms | 421.39 ms | 23.29 ms |
1d86dd6 | 405.14 ms | 411.06 ms | 5.92 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0677344 | 17.73 MiB | 19.81 MiB | 2.07 MiB |
52a8031+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
22e31b6 | 17.73 MiB | 19.84 MiB | 2.10 MiB |
52c0562 | 17.73 MiB | 20.11 MiB | 2.38 MiB |
0ebca77 | 17.73 MiB | 19.95 MiB | 2.21 MiB |
e73f4ed+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
9433f35 | 17.73 MiB | 19.81 MiB | 2.08 MiB |
148f924 | 17.73 MiB | 19.94 MiB | 2.21 MiB |
457e29f | 17.73 MiB | 19.84 MiB | 2.10 MiB |
1d86dd6 | 17.73 MiB | 19.86 MiB | 2.12 MiB |
Previous results on branch: v6
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2d6b4a9 | 484.00 ms | 499.49 ms | 15.49 ms |
3524c94 | 482.39 ms | 502.77 ms | 20.38 ms |
f77a902 | 484.04 ms | 487.57 ms | 3.53 ms |
170d40e | 442.90 ms | 453.70 ms | 10.80 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2d6b4a9 | 17.74 MiB | 20.06 MiB | 2.33 MiB |
3524c94 | 17.74 MiB | 20.06 MiB | 2.33 MiB |
f77a902 | 17.74 MiB | 20.06 MiB | 2.33 MiB |
170d40e | 17.74 MiB | 20.06 MiB | 2.33 MiB |
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5c9b8b+dirty | 1258.57 ms | 1267.32 ms | 8.75 ms |
0db0c72+dirty | 1275.02 ms | 1285.84 ms | 10.82 ms |
76d1baf+dirty | 1244.10 ms | 1268.52 ms | 24.42 ms |
1c65324+dirty | 1235.17 ms | 1235.08 ms | -0.09 ms |
e2b64fe+dirty | 1232.22 ms | 1255.20 ms | 22.98 ms |
8900e1a+dirty | 1210.27 ms | 1218.66 ms | 8.39 ms |
5571a20+dirty | 1203.57 ms | 1204.57 ms | 1.00 ms |
e73f4ed+dirty | 1243.27 ms | 1244.52 ms | 1.25 ms |
e73d82f+dirty | 1207.52 ms | 1216.73 ms | 9.21 ms |
d7401ac+dirty | 1252.38 ms | 1275.04 ms | 22.66 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5c9b8b+dirty | 2.36 MiB | 2.87 MiB | 520.43 KiB |
0db0c72+dirty | 2.36 MiB | 2.84 MiB | 487.01 KiB |
76d1baf+dirty | 2.36 MiB | 2.82 MiB | 469.45 KiB |
1c65324+dirty | 2.36 MiB | 3.04 MiB | 698.64 KiB |
e2b64fe+dirty | 2.36 MiB | 2.85 MiB | 495.80 KiB |
8900e1a+dirty | 2.36 MiB | 2.83 MiB | 479.25 KiB |
5571a20+dirty | 2.36 MiB | 2.92 MiB | 569.93 KiB |
e73f4ed+dirty | 2.36 MiB | 2.82 MiB | 469.44 KiB |
e73d82f+dirty | 2.36 MiB | 3.08 MiB | 734.23 KiB |
d7401ac+dirty | 2.36 MiB | 2.83 MiB | 481.14 KiB |
Previous results on branch: v6
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3524c94+dirty | 1232.23 ms | 1234.77 ms | 2.54 ms |
2d6b4a9+dirty | 1219.80 ms | 1229.06 ms | 9.26 ms |
170d40e+dirty | 1232.12 ms | 1228.04 ms | -4.08 ms |
f77a902+dirty | 1227.09 ms | 1226.74 ms | -0.35 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3524c94+dirty | 2.36 MiB | 3.08 MiB | 733.61 KiB |
2d6b4a9+dirty | 2.36 MiB | 3.08 MiB | 733.23 KiB |
170d40e+dirty | 2.36 MiB | 3.08 MiB | 733.66 KiB |
f77a902+dirty | 2.36 MiB | 3.08 MiB | 733.32 KiB |
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5c9b8b+dirty | 1276.90 ms | 1280.92 ms | 4.02 ms |
0db0c72+dirty | 1258.88 ms | 1262.52 ms | 3.64 ms |
76d1baf+dirty | 1245.00 ms | 1257.76 ms | 12.76 ms |
1c65324+dirty | 1239.71 ms | 1239.86 ms | 0.15 ms |
e2b64fe+dirty | 1285.78 ms | 1297.56 ms | 11.78 ms |
8900e1a+dirty | 1268.36 ms | 1273.04 ms | 4.68 ms |
5571a20+dirty | 1228.09 ms | 1233.45 ms | 5.36 ms |
e73f4ed+dirty | 1282.90 ms | 1309.30 ms | 26.40 ms |
e73d82f+dirty | 1231.20 ms | 1228.81 ms | -2.40 ms |
d7401ac+dirty | 1288.10 ms | 1289.54 ms | 1.44 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5c9b8b+dirty | 2.92 MiB | 3.43 MiB | 524.50 KiB |
0db0c72+dirty | 2.92 MiB | 3.40 MiB | 492.71 KiB |
76d1baf+dirty | 2.92 MiB | 3.38 MiB | 475.74 KiB |
1c65324+dirty | 2.92 MiB | 3.61 MiB | 705.56 KiB |
e2b64fe+dirty | 2.92 MiB | 3.41 MiB | 499.97 KiB |
8900e1a+dirty | 2.92 MiB | 3.39 MiB | 485.96 KiB |
5571a20+dirty | 2.92 MiB | 3.48 MiB | 575.54 KiB |
e73f4ed+dirty | 2.92 MiB | 3.38 MiB | 475.71 KiB |
e73d82f+dirty | 2.92 MiB | 3.64 MiB | 740.56 KiB |
d7401ac+dirty | 2.92 MiB | 3.40 MiB | 488.06 KiB |
Previous results on branch: v6
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3524c94+dirty | 1230.96 ms | 1241.08 ms | 10.12 ms |
2d6b4a9+dirty | 1236.09 ms | 1234.84 ms | -1.24 ms |
170d40e+dirty | 1231.92 ms | 1226.92 ms | -5.00 ms |
f77a902+dirty | 1223.83 ms | 1227.98 ms | 4.15 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3524c94+dirty | 2.92 MiB | 3.64 MiB | 739.83 KiB |
2d6b4a9+dirty | 2.92 MiB | 3.64 MiB | 739.48 KiB |
170d40e+dirty | 2.92 MiB | 3.64 MiB | 739.87 KiB |
f77a902+dirty | 2.92 MiB | 3.64 MiB | 739.16 KiB |
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
- Bump Cocoa SDK from v8.36.0 to v8.37.0 ([#4156](https://github.com/getsentry/sentry-react-native/pull/4156)) | ||
- [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#8370) | ||
- [diff](https://github.com/getsentry/sentry-cocoa/compare/8.36.0...8.37.0) | ||
- Bump Android SDK from v7.14.0 to v7.15.0 ([#4161](https://github.com/getsentry/sentry-react-native/pull/4161)) | ||
- [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#7150) | ||
- [diff](https://github.com/getsentry/sentry-java/compare/7.14.0...7.15.0) | ||
|
||
## 6.0.0-rc.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion:
we could add this on top of the latest version, just like the JavaScript and Capacitor SDKs are doing:
<!-- prettier-ignore-start -->
> [!IMPORTANT]
> If you are upgrading to the `6.x` versions of the SDK from `5.x` or earlier, make sure you follow our
> [migration guide](https://docs.sentry.io/platforms/react-native/migration/) first.
<!-- prettier-ignore-end -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some non-blocking feedback, LGTM!
Should we wait for #4155 before merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
@lucas-zimerman I was about to remove the debug keystores for the perf. But I checked the git history and looks like they were kept intentionally de7da04#diff-7565b850098ef1f67f8497d19130712470bada9d5cbf9b6c669cab1954d4bc65R44 |
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Reviewed code only
This PR tracks progress on the next major version of the Sentry React Native SDK version 6.
#skip-changelog
Related PRs