Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Updates documentation and scripts for the separate macOS sample app #4138

Merged
merged 14 commits into from
Oct 2, 2024

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Oct 2, 2024

Based on: #4132

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Updates documentation and scripts for the separate macOS sample app

💡 Motivation and Context

Failure to build the macOS app with the new architecture.

💚 How did you test it?

Run the scripts locally

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@antonis antonis changed the title Misc: Updates documentation and scripts for the separate macOS sample app misc: Updates documentation and scripts for the separate macOS sample app Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1235.85 ms 1229.41 ms -6.44 ms
Size 2.36 MiB 3.08 MiB 733.34 KiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
f77a902+dirty 1227.09 ms 1226.74 ms -0.35 ms

App size

Revision Plain With Sentry Diff
f77a902+dirty 2.36 MiB 3.08 MiB 733.32 KiB

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 444.94 ms 500.26 ms 55.32 ms
Size 7.15 MiB 8.34 MiB 1.19 MiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
f77a902+dirty 478.49 ms 516.40 ms 37.91 ms

App size

Revision Plain With Sentry Diff
f77a902+dirty 7.15 MiB 8.34 MiB 1.19 MiB

Copy link
Contributor

github-actions bot commented Oct 2, 2024

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1247.57 ms 1255.04 ms 7.47 ms
Size 2.92 MiB 3.64 MiB 739.45 KiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
f77a902+dirty 1223.83 ms 1227.98 ms 4.15 ms

App size

Revision Plain With Sentry Diff
f77a902+dirty 2.92 MiB 3.64 MiB 739.16 KiB

Base automatically changed from @krystofwoldrich/split-react-native-and-macos-samples to v6 October 2, 2024 08:57
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good.

@krystofwoldrich krystofwoldrich merged commit 518e7fa into v6 Oct 2, 2024
16 of 17 checks passed
@krystofwoldrich krystofwoldrich deleted the antonis/macos-sample-split-doc-update branch October 2, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants