Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Updates documentation and scripts for the separate macOS sample app #4138

Merged
merged 14 commits into from
Oct 2, 2024
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,25 @@ yarn run-ios --configuration Release
yarn run-android --variant=release
```

## Running the macOS sample

Head to the macOS sample root directory:

```sh
cd samples/react-native-macos/
yarn
bundle install
yarn pod-install-legacy
```

You can now build and run the project from command line:
```sh
yarn react-native run-macos
```
or by openning the `samples/react-native-macos/macos/sentry-react-native-sample.xcworkspace`.

_Note that the new architecture is not supported for the macOS sample at this point._

### Optional
You can optionally start the Metro bundler if you want to control where it runs:

Expand Down
2 changes: 0 additions & 2 deletions samples/react-native-macos/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
"lint": "npx eslint . --ext .js,.jsx,.ts,.tsx",
"fix": "npx eslint . --ext .js,.jsx,.ts,.tsx --fix",
"type-check": "tsc --noEmit",
"pod-install": "cd macos; RCT_NEW_ARCH_ENABLED=1 bundle exec pod install; cd ..",
"pod-install-production": "cd macos; PRODUCTION=1 RCT_NEW_ARCH_ENABLED=1 bundle exec pod install; cd ..",
"pod-install-legacy": "cd macos; bundle exec pod install; cd ..",
"pod-install-legacy-production": "cd macos; PRODUCTION=1 bundle exec pod install; cd ..",
"clean-macos": "cd macos; rm -rf Podfile.lock Pods build; cd ..",
Expand Down
Loading