-
-
Couldn't load subscription status.
- Fork 353
feat(session-replay): Adds replaysSessionQuality option #5001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bd825c3
feat(session-replay): Adds replaysSessionQuality option
antonis 4cfa29a
Adds changelog
antonis 56117c6
Move RNSentryReplayQuality to the correct folder
antonis f326ff2
Update changelog
antonis b91669b
Mention mobile in the changelog
antonis 2c06259
Merge branch 'main' into antonis/expose-replaysSessionQuality
antonis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| #import <Foundation/Foundation.h> | ||
|
|
||
| NS_ASSUME_NONNULL_BEGIN | ||
|
|
||
| typedef NS_ENUM(NSInteger, SentryReplayQuality); | ||
|
|
||
| @interface RNSentryReplayQuality : NSObject | ||
|
|
||
| + (SentryReplayQuality)parseReplayQuality:(NSString *_Nullable)qualityString; | ||
|
|
||
| @end | ||
|
|
||
| NS_ASSUME_NONNULL_END |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| #import "RNSentryReplayQuality.h" | ||
| @import Sentry; | ||
|
|
||
| @implementation RNSentryReplayQuality | ||
|
|
||
| + (SentryReplayQuality)parseReplayQuality:(NSString *_Nullable)qualityString | ||
| { | ||
| if (qualityString == nil) { | ||
| return SentryReplayQualityMedium; | ||
| } | ||
|
|
||
| NSString *lowercaseQuality = [qualityString lowercaseString]; | ||
|
|
||
| if ([lowercaseQuality isEqualToString:@"low"]) { | ||
| return SentryReplayQualityLow; | ||
| } else if ([lowercaseQuality isEqualToString:@"medium"]) { | ||
| return SentryReplayQualityMedium; | ||
| } else if ([lowercaseQuality isEqualToString:@"high"]) { | ||
| return SentryReplayQualityHigh; | ||
| } else { | ||
| return SentryReplayQualityMedium; | ||
| } | ||
| } | ||
|
|
||
| @end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe worth mentioning it affects only mobile replays
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick review and the feedback @romtsn 🙇
Updated with b91669b. Also updated the doc getsentry/sentry-docs@b47cb87