Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Jul 21, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Adds replaysSessionQuality option

Docs PR getsentry/sentry-docs#14412

💡 Motivation and Context

Fixes #4487

💚 How did you test it?

Manual, CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 2c06259

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 449.72 ms 444.62 ms -5.10 ms
Size 17.75 MiB 20.15 MiB 2.41 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
866f143 594.27 ms 602.00 ms 7.73 ms
df5da5d 425.55 ms 432.96 ms 7.41 ms
1f1c420 403.32 ms 411.98 ms 8.66 ms
a3aad2b 453.57 ms 463.62 ms 10.05 ms
bd87539 403.50 ms 395.47 ms -8.03 ms
071ae5c 393.64 ms 406.60 ms 12.96 ms
6715c24 419.21 ms 416.43 ms -2.78 ms
e12044e 453.78 ms 437.58 ms -16.20 ms
f0b931f 447.12 ms 430.32 ms -16.80 ms
f25ae46 459.92 ms 451.78 ms -8.14 ms

App size

Revision Plain With Sentry Diff
866f143 17.75 MiB 20.15 MiB 2.40 MiB
df5da5d 17.75 MiB 20.15 MiB 2.40 MiB
1f1c420 17.75 MiB 20.15 MiB 2.40 MiB
a3aad2b 17.75 MiB 20.15 MiB 2.40 MiB
bd87539 17.75 MiB 20.15 MiB 2.40 MiB
071ae5c 17.75 MiB 20.15 MiB 2.41 MiB
6715c24 17.75 MiB 20.15 MiB 2.40 MiB
e12044e 17.75 MiB 20.15 MiB 2.40 MiB
f0b931f 17.75 MiB 20.15 MiB 2.41 MiB
f25ae46 17.75 MiB 20.15 MiB 2.40 MiB

Previous results on branch: antonis/expose-replaysSessionQuality

Startup times

Revision Plain With Sentry Diff
70433d2 384.94 ms 367.37 ms -17.57 ms

App size

Revision Plain With Sentry Diff
70433d2 17.75 MiB 20.15 MiB 2.41 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 343.17 ms 416.82 ms 73.65 ms
Size 7.15 MiB 8.42 MiB 1.27 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a8a0930+dirty 452.56 ms 446.10 ms -6.45 ms
c5c2e71+dirty 400.40 ms 452.36 ms 51.96 ms
ab18954+dirty 376.65 ms 376.82 ms 0.17 ms
df5da5d+dirty 415.54 ms 456.96 ms 41.42 ms
071ae5c+dirty 342.42 ms 400.02 ms 57.60 ms
531450c+dirty 337.17 ms 362.67 ms 25.50 ms
69721ae+dirty 423.63 ms 417.34 ms -6.29 ms
f25ae46+dirty 366.14 ms 367.96 ms 1.82 ms
f2c6fa5+dirty 435.84 ms 433.84 ms -2.00 ms
9f14d9d+dirty 421.40 ms 454.52 ms 33.12 ms

App size

Revision Plain With Sentry Diff
a8a0930+dirty 7.15 MiB 8.42 MiB 1.26 MiB
c5c2e71+dirty 7.15 MiB 8.42 MiB 1.27 MiB
ab18954+dirty 7.15 MiB 8.42 MiB 1.26 MiB
df5da5d+dirty 7.15 MiB 8.42 MiB 1.26 MiB
071ae5c+dirty 7.15 MiB 8.42 MiB 1.27 MiB
531450c+dirty 7.15 MiB 8.42 MiB 1.26 MiB
69721ae+dirty 7.15 MiB 8.42 MiB 1.26 MiB
f25ae46+dirty 7.15 MiB 8.42 MiB 1.26 MiB
f2c6fa5+dirty 7.15 MiB 8.42 MiB 1.26 MiB
9f14d9d+dirty 7.15 MiB 8.42 MiB 1.27 MiB

Previous results on branch: antonis/expose-replaysSessionQuality

Startup times

Revision Plain With Sentry Diff
70433d2+dirty 393.33 ms 433.31 ms 39.98 ms

App size

Revision Plain With Sentry Diff
70433d2+dirty 7.15 MiB 8.42 MiB 1.27 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.06 ms 1237.56 ms 11.50 ms
Size 2.63 MiB 3.81 MiB 1.18 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9f14d9d+dirty 1228.51 ms 1233.00 ms 4.49 ms
df5da5d+dirty 1235.98 ms 1243.41 ms 7.43 ms
6e8a851+dirty 1227.96 ms 1235.61 ms 7.65 ms
a3aad2b+dirty 1196.88 ms 1205.52 ms 8.65 ms
398e5d0+dirty 1225.30 ms 1219.94 ms -5.36 ms
9e3030a+dirty 1215.35 ms 1234.80 ms 19.45 ms
8bd8033+dirty 1213.33 ms 1220.88 ms 7.55 ms
940bd65+dirty 1216.88 ms 1225.23 ms 8.35 ms
d18ddb1+dirty 1209.74 ms 1209.65 ms -0.10 ms
9167f73+dirty 1230.79 ms 1230.63 ms -0.17 ms

App size

Revision Plain With Sentry Diff
9f14d9d+dirty 2.63 MiB 3.81 MiB 1.18 MiB
df5da5d+dirty 2.63 MiB 3.78 MiB 1.15 MiB
6e8a851+dirty 2.63 MiB 3.78 MiB 1.15 MiB
a3aad2b+dirty 2.63 MiB 3.80 MiB 1.17 MiB
398e5d0+dirty 2.63 MiB 3.79 MiB 1.15 MiB
9e3030a+dirty 2.63 MiB 3.79 MiB 1.15 MiB
8bd8033+dirty 2.63 MiB 3.78 MiB 1.15 MiB
940bd65+dirty 2.63 MiB 3.78 MiB 1.15 MiB
d18ddb1+dirty 2.63 MiB 3.80 MiB 1.17 MiB
9167f73+dirty 2.63 MiB 3.79 MiB 1.15 MiB

Previous results on branch: antonis/expose-replaysSessionQuality

Startup times

Revision Plain With Sentry Diff
70433d2+dirty 1205.98 ms 1218.88 ms 12.90 ms

App size

Revision Plain With Sentry Diff
70433d2+dirty 2.63 MiB 3.81 MiB 1.18 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1224.08 ms 1221.92 ms -2.16 ms
Size 3.19 MiB 4.38 MiB 1.19 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9f14d9d+dirty 1212.42 ms 1211.50 ms -0.92 ms
940bd65+dirty 1224.39 ms 1215.57 ms -8.82 ms
b4d6bde+dirty 1218.73 ms 1223.26 ms 4.53 ms
a3aad2b+dirty 1213.89 ms 1224.52 ms 10.63 ms
1f1c420+dirty 1238.06 ms 1234.04 ms -4.02 ms
398e5d0+dirty 1226.17 ms 1232.82 ms 6.65 ms
9e3030a+dirty 1217.82 ms 1205.60 ms -12.21 ms
d18ddb1+dirty 1200.88 ms 1214.57 ms 13.69 ms
9167f73+dirty 1219.47 ms 1234.39 ms 14.92 ms
f25ae46+dirty 1241.73 ms 1239.10 ms -2.63 ms

App size

Revision Plain With Sentry Diff
9f14d9d+dirty 3.19 MiB 4.38 MiB 1.19 MiB
940bd65+dirty 3.19 MiB 4.35 MiB 1.16 MiB
b4d6bde+dirty 3.19 MiB 4.34 MiB 1.16 MiB
a3aad2b+dirty 3.19 MiB 4.36 MiB 1.17 MiB
1f1c420+dirty 3.19 MiB 4.34 MiB 1.16 MiB
398e5d0+dirty 3.19 MiB 4.35 MiB 1.17 MiB
9e3030a+dirty 3.19 MiB 4.35 MiB 1.17 MiB
d18ddb1+dirty 3.19 MiB 4.36 MiB 1.17 MiB
9167f73+dirty 3.19 MiB 4.35 MiB 1.17 MiB
f25ae46+dirty 3.19 MiB 4.36 MiB 1.17 MiB

Previous results on branch: antonis/expose-replaysSessionQuality

Startup times

Revision Plain With Sentry Diff
70433d2+dirty 1248.73 ms 1258.37 ms 9.63 ms

App size

Revision Plain With Sentry Diff
70433d2+dirty 3.19 MiB 4.38 MiB 1.19 MiB

@antonis antonis marked this pull request as ready for review July 21, 2025 11:37
@antonis antonis requested a review from lucas-zimerman as a code owner July 21, 2025 11:37

Sentry.init({
replaysSessionSampleRate: 1.0,
replaysSessionQuality: 'low', // possible values: low, medium (default), high
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe worth mentioning it affects only mobile replays

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick review and the feedback @romtsn 🙇
Updated with b91669b. Also updated the doc getsentry/sentry-docs@b47cb87

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antonis antonis enabled auto-merge (squash) July 22, 2025 06:02
@antonis antonis merged commit d079998 into main Jul 22, 2025
72 of 73 checks passed
@antonis antonis deleted the antonis/expose-replaysSessionQuality branch July 22, 2025 06:10
antonis added a commit to getsentry/sentry-docs that referenced this pull request Jul 30, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->

## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*

Adds `replaysSessionQuality` option in React Native session replay
options

## IS YOUR CHANGE URGENT?  

Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+

⚠️ Please merge after
getsentry/sentry-react-native#5001 is released

## SLA

- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!

## PRE-MERGE CHECKLIST

*Make sure you've checked the following before merging your changes:*

- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)

## LEGAL BOILERPLATE

<!-- Sentry employees and contractors can delete or ignore this section.
-->

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.

## EXTRA RESOURCES

- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose quality option in the replay integration

4 participants