Skip to content

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py force-pushed the neel/trace-ignore-status branch from 89737d1 to 5d20e1d Compare September 25, 2025 13:06
@sl0thentr0py sl0thentr0py requested a review from solnic September 25, 2025 13:13
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.41%. Comparing base (fe2ce71) to head (83319b2).
⚠️ Report is 1 commits behind head on 6.0-dev.

Additional details and impacted files
@@             Coverage Diff             @@
##           6.0-dev    #2725      +/-   ##
===========================================
+ Coverage    97.36%   97.41%   +0.05%     
===========================================
  Files          142      142              
  Lines         5580     5611      +31     
===========================================
+ Hits          5433     5466      +33     
+ Misses         147      145       -2     
Components Coverage Δ
sentry-ruby 97.71% <100.00%> (+0.01%) ⬆️
sentry-rails 96.50% <ø> (ø)
sentry-sidekiq 96.57% <ø> (+0.79%) ⬆️
sentry-resque 94.44% <ø> (ø)
sentry-delayed_job 94.68% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/configuration.rb 98.47% <100.00%> (+0.06%) ⬆️
sentry-ruby/lib/sentry/transaction.rb 98.36% <100.00%> (+0.14%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of minor questions. LGTM in general.

@sl0thentr0py sl0thentr0py force-pushed the neel/trace-ignore-status branch from d9c903a to 83319b2 Compare September 26, 2025 09:34
@sl0thentr0py sl0thentr0py merged commit 42059db into 6.0-dev Sep 26, 2025
138 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/trace-ignore-status branch September 26, 2025 10:19
@sl0thentr0py sl0thentr0py mentioned this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants