ref: Rearchitect the log and slog Integrations #268
Conversation
There was a problem hiding this comment.
Two general points:
-
As opposed to before, the user now has to call
log::set_max_level_filtermanually. We need to clearly document that in the migration notes (Changelog), as otherwise suddenly logs will just be suppressed. -
What's now not really possible is to create breadcrumbs with a higher level than the inner max level. Following example: We may want breadcrumbs on TRACE level, but only log INFO to stderr. Do you think that is something we may be able to achieve? My initial hunch says this is too much of an edge case and can be solved in the log stash, too.
| @@ -41,6 +41,7 @@ | |||
| #![doc(html_favicon_url = "https://sentry-brand.storage.googleapis.com/favicon.ico")] | |||
| #![doc(html_logo_url = "https://sentry-brand.storage.googleapis.com/sentry-glyph-black.png")] | |||
| #![warn(missing_docs)] | |||
| #![allow(clippy::match_like_matches_macro)] | |||
There was a problem hiding this comment.
Instead of allowing this, can we just fix this?
There was a problem hiding this comment.
not unless we break the MSRV, since matches! is a 1.42 feature.
* master: (59 commits) fix: Correctly apply environment from env (#293) fix: Make Rust 1.48 clippy happy (#294) docs: Document integrations and the Hub better (#291) ref: Remove deprecated error-chain and failure crates (#290) release: 0.21.0 meta: Update Changelog feat: End sessions with explicit status (#289) fix: Scope transaction name can be overriden in sentry-actix (#287) fix: sentry-actix should not capture client errors (#286) fix: Clean up sentry-actix toml (#285) ref: Remove empty integrations (#283) feat: Add support for actix-web 3 (#282) feat: Preliminary work to integrate Performance Monitoring (#276) ref: Introduce a SessionFlusher (#279) fix: Set a default environment based on debug_assertions (#280) ref: Rearchitect the log and slog Integrations (#268) ref: Deprecate public fields on Integrations (#267) ci: Make testfast actually fast (#273) fix: Update surf and unbreak CI (#274) ci: Use smarter cache action (#272) ...
In hindsight, putting all the filters/mappers on the Hub/Client-bound Integration was a mistake, and all that should be inside a lightweight logger.