-
Notifications
You must be signed in to change notification settings - Fork 212
Use structured logging and send it to Sentry #1151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Integrating this with rustwide will require waiting until the next sentry release so we get the changes in getsentry/sentry-rust#268. |
It seems it was released in 0.21.0, so we could give this another go.
so the remaining question is, does sentry have value for us even without graceful shutdown? Or should we find a quickfix for graceful shutdown first? |
Absolutely yes; we may need to explicitly call flush on a schedule or something, but that's still a ton more alerts than "none at all". We just might lose a few when restarting the server, which is infrequent.
I do not have time to tackle this at the moment :( happy for someone else to pick it up |
Sentry has been setup already following the instructions in https://forge.rust-lang.org/infra/docs/sentry.html. We could add sentry integration to docs.rs, see rust-lang/crates.io#2961 for an example. There are docs at https://docs.sentry.io/platforms/rust/ and https://docs.rs/sentry/0.20.1/sentry/#quickstart.
Note that sentry has a drop guard for flushing messages, so we should consider implementing #1150 first to avoid losing logs.
The text was updated successfully, but these errors were encountered: