Skip to content

Commit

Permalink
feat(grouping): Exclude sentry-java sdk frames from group and inapp (#…
Browse files Browse the repository at this point in the history 
…60691)
  • Loading branch information
@romtsn
romtsn authored Dec 1, 2023
1 parent 7920f8e commit 7e66009
Show file tree
Hide file tree
Showing 11 changed files with 160 additions and 155 deletions.
1 change: 1 addition & 0 deletions src/sentry/grouping/enhancer/enhancement-configs/newstyle@2023-01-11.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,7 @@ module:org.glassfish.* -app
module:org.jboss.* -app
module:feign.* -app
module:io.opentelemetry.* -app
module:io.sentry.* -app -group

## kotlin
module:kotlin.* -app
Expand Down
14 changes: 7 additions & 7 deletions tests/sentry/grouping/grouping_inputs/stacktrace-collapse-recursion.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,55 +4,55 @@
{
"function": "main",
"abs_path": "Application.java",
"module": "io.sentry.example.Application",
"module": "com.example.Application",
"filename": "Application.java",
"lineno": 13,
"in_app": false
},
{
"function": "normalFunc",
"abs_path": "Application.java",
"module": "io.sentry.example.Application",
"module": "com.example.Application",
"filename": "Application.java",
"lineno": 20,
"in_app": false
},
{
"function": "recurFunc",
"abs_path": "Application.java",
"module": "io.sentry.example.Application",
"module": "com.example.Application",
"filename": "Application.java",
"lineno": 27,
"in_app": false
},
{
"function": "recurFunc",
"abs_path": "Application.java",
"module": "io.sentry.example.Application",
"module": "com.example.Application",
"filename": "Application.java",
"lineno": 27,
"in_app": false
},
{
"function": "recurFunc",
"abs_path": "Application.java",
"module": "io.sentry.example.Application",
"module": "com.example.Application",
"filename": "Application.java",
"lineno": 27,
"in_app": false
},
{
"function": "recurFunc",
"abs_path": "Application.java",
"module": "io.sentry.example.Application",
"module": "com.example.Application",
"filename": "Application.java",
"lineno": 25,
"in_app": false
},
{
"function": "throwError",
"abs_path": "Application.java",
"module": "io.sentry.example.Application",
"module": "com.example.Application",
"filename": "Application.java",
"lineno": 32,
"in_app": false
Expand Down
32 changes: 16 additions & 16 deletions ...t_variants/test_event_hash_variant/legacy@2019_03_12/stacktrace_collapse_recursion.pysnap
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
created: '2020-02-26T19:54:28.809960Z'
created: '2023-11-28T16:31:35.546537Z'
creator: sentry
source: tests/sentry/grouping/test_variants.py
---
Expand All @@ -10,7 +10,7 @@ app:
stacktrace (ignored because hash matches system variant)
frame* (frame considered in-app because no frame is in-app)
module*
"io.sentry.example.Application"
"com.example.Application"
filename (module takes precedence)
"Application.java"
function*
Expand All @@ -19,7 +19,7 @@ app:
13
frame* (frame considered in-app because no frame is in-app)
module*
"io.sentry.example.Application"
"com.example.Application"
filename (module takes precedence)
"Application.java"
function*
Expand All @@ -28,7 +28,7 @@ app:
20
frame* (frame considered in-app because no frame is in-app)
module*
"io.sentry.example.Application"
"com.example.Application"
filename (module takes precedence)
"Application.java"
function*
Expand All @@ -37,7 +37,7 @@ app:
27
frame (ignored due to recursion)
module*
"io.sentry.example.Application"
"com.example.Application"
filename (module takes precedence)
"Application.java"
function*
Expand All @@ -46,7 +46,7 @@ app:
27
frame (ignored due to recursion)
module*
"io.sentry.example.Application"
"com.example.Application"
filename (module takes precedence)
"Application.java"
function*
Expand All @@ -55,7 +55,7 @@ app:
27
frame* (frame considered in-app because no frame is in-app)
module*
"io.sentry.example.Application"
"com.example.Application"
filename (module takes precedence)
"Application.java"
function*
Expand All @@ -64,7 +64,7 @@ app:
25
frame* (frame considered in-app because no frame is in-app)
module*
"io.sentry.example.Application"
"com.example.Application"
filename (module takes precedence)
"Application.java"
function*
Expand All @@ -73,13 +73,13 @@ app:
32
--------------------------------------------------------------------------
system:
hash: "894c3489e2ade384dc107bca6829d134"
hash: "9bdadae4fa003cef6cf460ff1325e54b"
component:
system*
stacktrace*
frame*
module*
"io.sentry.example.Application"
"com.example.Application"
filename (module takes precedence)
"Application.java"
function*
Expand All @@ -88,7 +88,7 @@ system:
13
frame*
module*
"io.sentry.example.Application"
"com.example.Application"
filename (module takes precedence)
"Application.java"
function*
Expand All @@ -97,7 +97,7 @@ system:
20
frame*
module*
"io.sentry.example.Application"
"com.example.Application"
filename (module takes precedence)
"Application.java"
function*
Expand All @@ -106,7 +106,7 @@ system:
27
frame (ignored due to recursion)
module*
"io.sentry.example.Application"
"com.example.Application"
filename (module takes precedence)
"Application.java"
function*
Expand All @@ -115,7 +115,7 @@ system:
27
frame (ignored due to recursion)
module*
"io.sentry.example.Application"
"com.example.Application"
filename (module takes precedence)
"Application.java"
function*
Expand All @@ -124,7 +124,7 @@ system:
27
frame*
module*
"io.sentry.example.Application"
"com.example.Application"
filename (module takes precedence)
"Application.java"
function*
Expand All @@ -133,7 +133,7 @@ system:
25
frame*
module*
"io.sentry.example.Application"
"com.example.Application"
filename (module takes precedence)
"Application.java"
function*
Expand Down
Loading

0 comments on commit 7e66009

Please sign in to comment.