-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grouping): Exclude sentry-java sdk frames from group and inapp #60691
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #60691 +/- ##
==========================================
+ Coverage 80.76% 80.88% +0.12%
==========================================
Files 5185 5185
Lines 227509 227514 +5
Branches 38244 38247 +3
==========================================
+ Hits 183742 184029 +287
+ Misses 38143 37861 -282
Partials 5624 5624 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, if I understand correctly, this doesn't affect current issues, just ones which will come from the new version of the SDK. Is that right?
yes, that's right! |
@lobsterkatie can we get this approved, or do you see any problems with that? :) |
@lobsterkatie also just to be 100% sure - once this is merged, the new rule is applied immediately for new events, correct? |
Yes, it will be applied immediately. But I checked out getsentry/sentry-java#3021 and it seems like currently, no events have sentry frames, correct? If that's true, then this is fine to merge. |
@lobsterkatie yep, correct. Could you please give an approval then? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup! 🚢
This is necessary for the sentry-java sdk to not mess up grouping, because we'll start sending sdk frames for fatals from the next major version (relevant pr: getsentry/sentry-java#3021)
Also changed
io.sentry
tocom.example
instacktrace-collapse-recursion
snapshot so it's not affected by this change