Skip to content

Commit

Permalink
fix(InstallWizard): Fix exception when InstallWizard completed (#14092)
Browse files Browse the repository at this point in the history
Since we don't have tests for the submit flow, we did not catch a regression from #13798 where the event handler was not bound to the class instance, causing an `this.setState` is not defined error when submitting the welcome form.

This patch fixes the issue. Will add tests to cover this soon after.
  • Loading branch information
BYK authored Jul 19, 2019
1 parent 9dc1ed0 commit cbc7b96
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions src/sentry/static/sentry/app/views/app.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -200,16 +200,13 @@ class App extends React.Component {
e.stopPropagation();
}

onConfigured() {
this.setState({needsUpgrade: false});
}
onConfigured = () => this.setState({needsUpgrade: false});

handleNewsletterConsent = () => {
// this is somewhat hackish
// this is somewhat hackish
handleNewsletterConsent = () =>
this.setState({
newsletterConsentPrompt: false,
});
};

handleGlobalModalClose = () => {
if (!this.mainContainerRef) {
Expand Down

0 comments on commit cbc7b96

Please sign in to comment.