Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Convert app.jsx to ES6 #13798

Merged
merged 1 commit into from
Jun 25, 2019
Merged

ref: Convert app.jsx to ES6 #13798

merged 1 commit into from
Jun 25, 2019

Conversation

lynnagara
Copy link
Member

Uses withConfig HoC instead of connecting to the ConfigStore directly

This is required for #13786

Uses withConfig HoC instead of connecting to the ConfigStore directly

This is required for #13786
@lynnagara lynnagara requested a review from a team June 24, 2019 23:14
@lynnagara lynnagara merged commit 634c2a7 into master Jun 25, 2019
@lynnagara lynnagara deleted the convert-app-to-es6 branch June 25, 2019 17:32
BYK added a commit that referenced this pull request Jul 19, 2019
Since we don't have tests for the submit flow, we did not catch a regression from #13798 where the event handler was not bound to the class instance, causing an `this.setState` is not defined error when submitting the welcome form.

This patch fixes the issue. Will add tests to cover this soon after.
BYK added a commit that referenced this pull request Jul 19, 2019
Since we don't have tests for the submit flow, we did not catch a regression from #13798 where the event handler was not bound to the class instance, causing an `this.setState` is not defined error when submitting the welcome form.

This patch fixes the issue. Will add tests to cover this soon after.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants