Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Missing clicks in DOM events #54291

Closed
michellewzhang opened this issue Aug 7, 2023 · 0 comments · Fixed by #55425
Closed

Bug: Missing clicks in DOM events #54291

michellewzhang opened this issue Aug 7, 2023 · 0 comments · Fixed by #55425
Assignees
@michellewzhang

Comments

@michellewzhang
Copy link
Member

michellewzhang commented Aug 7, 2023 •
edited
Loading

Issue:

Checkout this replay:

  • If you look at the timeline and breadcrumbs, you can see clicks in the first few seconds, but the DOM events tab is missing clicks until the first minute
  • Also, if you filter for just rage & dead clicks, only one shows up in DOM events, but the timeline shows a ton of rage & dead clicks

Solution:

  • After further investigation, we realized this bug is happening because certain clicks (both normal and rage/dead) are not mapped to HTML selectors, which means they don't show up in the DOM events tab.
  • We'll do a temporary fix by showing ALL of these clicks with an empty HTML box for now, but we'll will do further investigation to figure out why they are not mapped in the first place.
  • Next step: find and display mapped HTML, then correctly map the breadcrumbs to re-rendered HTML elements
@michellewzhang michellewzhang mentioned this issue Aug 8, 2023
Closed
@billyvg billyvg mentioned this issue Aug 14, 2023
Closed
@ryan953 ryan953 changed the title Missing clicks in DOM events when there are too many rage clicks Bug: Missing clicks in DOM events when there are too many rage clicks Aug 16, 2023
@michellewzhang michellewzhang changed the title Bug: Missing clicks in DOM events when there are too many rage clicks Bug: Missing clicks in DOM events Aug 29, 2023
@michellewzhang michellewzhang mentioned this issue Aug 29, 2023
Merged
michellewzhang added a commit that referenced this issue Aug 29, 2023
@michellewzhang
fix(replays): show all clicks in DOM events tab (#55378)
cec2d36 
Temporary fix for #54291; more
investigation to come

Show all clicks (both rage/dead and normal) in the DOM events tab (no
more missing clicks), but these are not yet mapped to HTML selectors.

Before:
<img width="1181" alt="SCR-20230829-kwjh"
src="https://github.com/getsentry/sentry/assets/56095982/c9bd2e8d-a321-4c40-9873-c2ac2bd21460">


After:
<img width="1206" alt="SCR-20230829-mcng"
src="https://github.com/getsentry/sentry/assets/56095982/ac3df2c6-65ec-4753-83ac-93ac3c730bd5">
@michellewzhang michellewzhang mentioned this issue Aug 30, 2023
Merged
@michellewzhang michellewzhang self-assigned this Aug 30, 2023
michellewzhang added a commit that referenced this issue Sep 5, 2023
@michellewzhang @ryan953
ref(replays): refactor rendering of DOM events (#55425)
37f0470 
Note: will add an acceptance test in a subsequent PR

Follow up to PR: #55378

Refactor the way we map breadcrumbs to events, so now the previously
missing DOM events show the mapped HTML too.
Closes #54291

Before:
<img width="1328" alt="Screenshot 2023-08-30 at 11 00 08 AM"
src="https://github.com/getsentry/sentry/assets/56095982/523f920d-8530-4e8e-8bb5-cf99c314ece7">
<img width="561" alt="SCR-20230830-kamy"
src="https://github.com/getsentry/sentry/assets/56095982/3226ea9b-494d-4d60-af63-d8a08b5a3655">

After:
<img width="1119" alt="SCR-20230830-kalp"
src="https://github.com/getsentry/sentry/assets/56095982/af112668-4282-486b-8185-8606561a264e">
<img width="571" alt="SCR-20230830-kanz"
src="https://github.com/getsentry/sentry/assets/56095982/b6b22c1c-16e6-4908-990d-4e350d45bc8c">

---------

Co-authored-by: Ryan Albrecht <ryan.albrecht@sentry.io>
EricHasegawa pushed a commit that referenced this issue Sep 6, 2023
@michellewzhang @ryan953 @EricHasegawa
ref(replays): refactor rendering of DOM events (#55425)
050784d 
Note: will add an acceptance test in a subsequent PR

Follow up to PR: #55378

Refactor the way we map breadcrumbs to events, so now the previously
missing DOM events show the mapped HTML too.
Closes #54291

Before:
<img width="1328" alt="Screenshot 2023-08-30 at 11 00 08 AM"
src="https://github.com/getsentry/sentry/assets/56095982/523f920d-8530-4e8e-8bb5-cf99c314ece7">
<img width="561" alt="SCR-20230830-kamy"
src="https://github.com/getsentry/sentry/assets/56095982/3226ea9b-494d-4d60-af63-d8a08b5a3655">

After:
<img width="1119" alt="SCR-20230830-kalp"
src="https://github.com/getsentry/sentry/assets/56095982/af112668-4282-486b-8185-8606561a264e">
<img width="571" alt="SCR-20230830-kanz"
src="https://github.com/getsentry/sentry/assets/56095982/b6b22c1c-16e6-4908-990d-4e350d45bc8c">

---------

Co-authored-by: Ryan Albrecht <ryan.albrecht@sentry.io>
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michellewzhang michellewzhang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref(replays): refactor rendering of DOM events getsentry/sentry
1 participant
@michellewzhang