fix(replays): show all clicks in DOM events tab #55378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
|
Can you make it so that it's not rendering those empty gray bars as well? |
ryan953
approved these changes
Aug 29, 2023
This was referenced Aug 30, 2023
michellewzhang
added a commit
that referenced
this pull request
Sep 5, 2023
Note: will add an acceptance test in a subsequent PR Follow up to PR: #55378 Refactor the way we map breadcrumbs to events, so now the previously missing DOM events show the mapped HTML too. Closes #54291 Before: <img width="1328" alt="Screenshot 2023-08-30 at 11 00 08 AM" src="https://github.com/getsentry/sentry/assets/56095982/523f920d-8530-4e8e-8bb5-cf99c314ece7"> <img width="561" alt="SCR-20230830-kamy" src="https://github.com/getsentry/sentry/assets/56095982/3226ea9b-494d-4d60-af63-d8a08b5a3655"> After: <img width="1119" alt="SCR-20230830-kalp" src="https://github.com/getsentry/sentry/assets/56095982/af112668-4282-486b-8185-8606561a264e"> <img width="571" alt="SCR-20230830-kanz" src="https://github.com/getsentry/sentry/assets/56095982/b6b22c1c-16e6-4908-990d-4e350d45bc8c"> --------- Co-authored-by: Ryan Albrecht <ryan.albrecht@sentry.io>
EricHasegawa
pushed a commit
that referenced
this pull request
Sep 6, 2023
Note: will add an acceptance test in a subsequent PR Follow up to PR: #55378 Refactor the way we map breadcrumbs to events, so now the previously missing DOM events show the mapped HTML too. Closes #54291 Before: <img width="1328" alt="Screenshot 2023-08-30 at 11 00 08 AM" src="https://github.com/getsentry/sentry/assets/56095982/523f920d-8530-4e8e-8bb5-cf99c314ece7"> <img width="561" alt="SCR-20230830-kamy" src="https://github.com/getsentry/sentry/assets/56095982/3226ea9b-494d-4d60-af63-d8a08b5a3655"> After: <img width="1119" alt="SCR-20230830-kalp" src="https://github.com/getsentry/sentry/assets/56095982/af112668-4282-486b-8185-8606561a264e"> <img width="571" alt="SCR-20230830-kanz" src="https://github.com/getsentry/sentry/assets/56095982/b6b22c1c-16e6-4908-990d-4e350d45bc8c"> --------- Co-authored-by: Ryan Albrecht <ryan.albrecht@sentry.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix for #54291; more investigation to come
Show all clicks (both rage/dead and normal) in the DOM events tab (no more missing clicks), but these are not yet mapped to HTML selectors.
Before:
After:
