Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Q4] Resource Module Work #60482

Closed
14 of 33 tasks
AbhiPrasad opened this issue Nov 22, 2023 · 3 comments
Closed
14 of 33 tasks

[Q4] Resource Module Work #60482

AbhiPrasad opened this issue Nov 22, 2023 · 3 comments
Assignees
@AbhiPrasad @DominikB2014

Comments

@AbhiPrasad
Copy link
Member

AbhiPrasad commented Nov 22, 2023 •
edited
Loading

Continuing work from #58723

#60424

[1] UI Fixes
Preview Give feedback
  6. Render blocking dropdown on resource summary page is cut off in small viewports #60552
    DominikB2014
  7. Remove type from resource module table #60553
    DominikB2014
  13. Link to docs for timing-allow-origin alert with examples #62647
    Migrated Waiting for: Product Owner

[2] Additional resource types
Preview Give feedback
  1. Support images #61161
    8 of 8
    DominikB2014
  3. Support resource.link #61139
    1 of 2
  5. Filter out resources injected into browser #60997

[3] Web Vitals module integration
Preview Give feedback
  1. Add resource module links to web vitals recommendations #63677
    Migrated

[4] Integration with Performance Issues and Span Waterfall
Preview Give feedback
  1. Add button to go from span description to resource summary page #60555
    AbhiPrasad
  2. Link relevant performance issues in resource summary page #61154

[5] Bundle Analysis
Preview Give feedback

[6] Resource paramaterization
Preview Give feedback

Stretch Goals
Preview Give feedback
  3. Make it easier to get URL from resource summary page #62630
    Migrated Product Area: Performance
  4. Setting timing-allow-origin does not work with Cloudfront CDN and compression #62685
    Migrated
Resource paramaterization proposal from Dom image
@AbhiPrasad
Copy link
Member Author

Some feedback from Ben about paramaterization

image

@DominikB2014 DominikB2014 mentioned this issue Nov 29, 2023
Merged
DominikB2014 added a commit that referenced this issue Nov 29, 2023
@DominikB2014 @AbhiPrasad
feat(browser-starfish): ui updates to resource module (#60795)
e91492e 
Fixes #60553 
And more work towards #60482 

1. Remove type column in resource module
2. Adds CTA to update SDK if resource sizes look off

![image](https://github.com/getsentry/sentry/assets/44422760/8eaa1311-ec24-463a-bc3a-6f694e26e73b)

3. remove some unused code for when we had decoded body size

---------

Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
This was referenced Nov 29, 2023
Merged
Merged
DominikB2014 added a commit that referenced this issue Nov 29, 2023
@DominikB2014
feat(browser-starfish): add span sample in resource summary page (#60823
c3de545 
)

Work for #60482 

See an example of a span from the resource summary page (same as hover
dropdown), when hovering over a page
<img width="691" alt="image"
src="https://github.com/getsentry/sentry/assets/44422760/cbcc9390-590a-4d04-99a5-919f79c3565a">
scefali pushed a commit that referenced this issue Nov 29, 2023
@DominikB2014 @AbhiPrasad
feat(browser-starfish): ui updates to resource module (#60795)
d7d749c 
Fixes #60553 
And more work towards #60482 

1. Remove type column in resource module
2. Adds CTA to update SDK if resource sizes look off

![image](https://github.com/getsentry/sentry/assets/44422760/8eaa1311-ec24-463a-bc3a-6f694e26e73b)

3. remove some unused code for when we had decoded body size

---------

Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
scefali pushed a commit that referenced this issue Nov 29, 2023
@DominikB2014
feat(browser-starfish): add span sample in resource summary page (#60823
3f28f06 
)

Work for #60482 

See an example of a span from the resource summary page (same as hover
dropdown), when hovering over a page
<img width="691" alt="image"
src="https://github.com/getsentry/sentry/assets/44422760/cbcc9390-590a-4d04-99a5-919f79c3565a">
This was referenced Dec 5, 2023
Merged
Merged
Merged
DominikB2014 added a commit that referenced this issue Dec 15, 2023
@DominikB2014
feat(browser-starfish): add example images in resource summary" (#61620)
4d47950 
Work for #60482 

Adds sample images to the resources summary. For example:

<img width="1256" alt="image"
src="https://github.com/getsentry/sentry/assets/44422760/e2dab868-2205-4545-920a-16d4c5e4737a">
This was referenced Dec 22, 2023
Merged
Merged
Merged
DominikB2014 added a commit that referenced this issue Jan 8, 2024
@DominikB2014
feat(browser-starfish): add initial ui to enable image view (#62223)
a989517 
Work for #60482 

1. Adds a basic UI to enable disable image view.

<img width="1264" alt="image"
src="https://github.com/getsentry/sentry/assets/44422760/a58d6ce6-7bc0-4edf-9a9f-5491fb1fac66">

2. When you select show only links the following is shown
<img width="1255" alt="image"
src="https://github.com/getsentry/sentry/assets/44422760/a804efe5-4481-4c4b-bc61-43fb72659d87">

3. If you select go to settings, you go to the performance page
settings.

4. If an image has an error, we will display the grey box again
<img width="753" alt="image"
src="https://github.com/getsentry/sentry/assets/44422760/2654013d-e9b3-4891-86c2-2ba48d6c2030">

A couple TODOs to actually use this
1. We don't have an image icon, going to work on that in a future PR, an
SVG is probably okay here?
2. We need to merge in #62131 and #62025 to have the actual setting
DominikB2014 added a commit that referenced this issue Jan 9, 2024
@DominikB2014
feat(browser-starfish): Add project settings endpoint for images (#62025
58a677f 
)

Work for #60482 

This PR adds a new endpoint to enable/disable images for the resource
module as a project settings.
Complements #62131 , this PR shall be merged and deployed first.

TODO: 
- [x] Add some more error handling
- [x] Add tests
<img width="767" alt="image"
src="https://github.com/getsentry/sentry/assets/44422760/84196e45-3311-459f-b16b-c7693a659063">
DominikB2014 added a commit that referenced this issue Jan 9, 2024
@DominikB2014
feat(browser-starfish): frontend project settings (#62131)
6e42048 
This PR complements the backend change here #62025, more work for #60482
This should be merged after

It adds to UI to enable/disable images from project settings.
trillville pushed a commit that referenced this issue Jan 19, 2024
@DominikB2014 @trillville
feat(browser-starfish): add initial ui to enable image view (#62223)
a348001 
Work for #60482 

1. Adds a basic UI to enable disable image view.

<img width="1264" alt="image"
src="https://github.com/getsentry/sentry/assets/44422760/a58d6ce6-7bc0-4edf-9a9f-5491fb1fac66">

2. When you select show only links the following is shown
<img width="1255" alt="image"
src="https://github.com/getsentry/sentry/assets/44422760/a804efe5-4481-4c4b-bc61-43fb72659d87">

3. If you select go to settings, you go to the performance page
settings.

4. If an image has an error, we will display the grey box again
<img width="753" alt="image"
src="https://github.com/getsentry/sentry/assets/44422760/2654013d-e9b3-4891-86c2-2ba48d6c2030">

A couple TODOs to actually use this
1. We don't have an image icon, going to work on that in a future PR, an
SVG is probably okay here?
2. We need to merge in #62131 and #62025 to have the actual setting
trillville pushed a commit that referenced this issue Jan 19, 2024
@DominikB2014 @trillville
feat(browser-starfish): Add project settings endpoint for images (#62025
ae2ccdf 
)

Work for #60482 

This PR adds a new endpoint to enable/disable images for the resource
module as a project settings.
Complements #62131 , this PR shall be merged and deployed first.

TODO: 
- [x] Add some more error handling
- [x] Add tests
<img width="767" alt="image"
src="https://github.com/getsentry/sentry/assets/44422760/84196e45-3311-459f-b16b-c7693a659063">
trillville pushed a commit that referenced this issue Jan 19, 2024
@DominikB2014 @trillville
feat(browser-starfish): frontend project settings (#62131)
c21e2c8 
This PR complements the backend change here #62025, more work for #60482
This should be merged after

It adds to UI to enable/disable images from project settings.
@gggritso gggritso mentioned this issue Jan 25, 2024
Open
@DominikB2014 DominikB2014 mentioned this issue Jan 26, 2024
Merged
@AbhiPrasad
Copy link
Member Author

Q4 is done - going to move everything over to https://github.com/orgs/getsentry/projects/193/views/1

@AbhiPrasad
Copy link
Member Author

We decided not to make follow up tasks for resource paramaterization because of time constraints

@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AbhiPrasad AbhiPrasad

@DominikB2014 DominikB2014

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AbhiPrasad @DominikB2014