Skip to content

chore(grouphistory): Stop using prev_history #102474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2025
Merged

chore(grouphistory): Stop using prev_history #102474

merged 1 commit into from
Oct 31, 2025

Conversation

@armenzg
Copy link
Member

@armenzg armenzg commented Oct 31, 2025 •
edited
Loading

While investigating #102470, I realized we don't actually use it for anything useful.

In order to delete the column, we first need to stop making use of it (see docs for instructions).

Next PR: #102672

@armenzg
chore(grouphistory): Stop using prev_history
e74500f 
While investigating #102470, I realized we don't actually use it for anything useful.

In order to delete the column, we first need to stop making any reference to it ([docs](https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns).
@armenzg armenzg self-assigned this Oct 31, 2025
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 31, 2025
armenzg
armenzg commented Oct 31, 2025
View reviewed changes
src/sentry/models/grouphistory.py
Copy link
Member Author

@armenzg armenzg Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can go straight into removing the usage of prev_history since it's already null.

First, if the column is either not nullable, or doesn't have a db_default set, then make a PR to make it nullable via null=True.

sentry/src/sentry/models/grouphistory.py

Lines 215 to 217 in 5871107

prev_history = FlexibleForeignKey(
"sentry.GroupHistory", null=True
) # This field has no immediate use, but might be useful.

src/sentry/testutils/factories.py
user_id: int | None = None,
team_id: int | None = None,
prev_history: GroupHistory | None = None,
prev_history_date: datetime | None = None,
Copy link
Member Author

@armenzg armenzg Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, this is the column which can be null or a datetime:

sentry/src/sentry/models/grouphistory.py

Lines 218 to 220 in 5871107

prev_history_date = models.DateTimeField(
null=True
) # This field is used to simplify query calculations.

tests/sentry/core/endpoints/test_team_time_to_resolution.py
GroupHistoryStatus.RESOLVED,
user_id=self.user.id,
prev_history=gh1,
prev_history_date=gh1.date_added,
Copy link
Member Author

@armenzg armenzg Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, the date_added field:

sentry/src/sentry/models/grouphistory.py

Line 221 in 5871107

date_added = models.DateTimeField(default=timezone.now)

@armenzg armenzg marked this pull request as ready for review October 31, 2025 13:33
@armenzg armenzg requested a review from a team as a code owner October 31, 2025 13:33
@armenzg armenzg enabled auto-merge (squash) October 31, 2025 13:33
cvxluo
cvxluo reviewed Oct 31, 2025
View reviewed changes
Copy link
Contributor

@cvxluo cvxluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we planning to remove prev_history but keep prev_history_date?

@armenzg
Copy link
Member Author

armenzg commented Oct 31, 2025

are we planning to remove prev_history but keep prev_history_date?

That's correct!

@armenzg armenzg disabled auto-merge October 31, 2025 16:34
@armenzg armenzg requested a review from cvxluo October 31, 2025 16:34
@armenzg armenzg enabled auto-merge (squash) October 31, 2025 16:35
@armenzg armenzg merged commit b06c951 into master Oct 31, 2025
71 checks passed
@armenzg armenzg deleted the 1/prev_history/allow_null/armenzg branch October 31, 2025 16:45
jjbayer pushed a commit that referenced this pull request Nov 3, 2025
@armenzg @jjbayer
chore(grouphistory): Stop using prev_history (#102474)
299c3d7 
While investigating #102470, I realized we don't actually use it for
anything useful.

In order to delete the column, we first need to stop making use of it
(see
[docs](https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns)
for instructions).
@armenzg armenzg mentioned this pull request Nov 4, 2025
Closed
armenzg added a commit that referenced this pull request Nov 4, 2025
@armenzg
chore(group_history): Remove db_constraint for prev_history
9f22f0d 
This is part of the required steps to remove a column from Sentry:
https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns.

This is a follow-up to #102474.

This fixes [SENTRY-5BX8](https://sentry.sentry.io/issues/6994851757/) and [SENTRY-5BXW](https://sentry.sentry.io/issues/6995699817/) which are happening since we switched to the bulk deletion model (#102580).
@armenzg armenzg mentioned this pull request Nov 4, 2025
Merged
armenzg added a commit that referenced this pull request Nov 4, 2025
@armenzg
chore(group_history): Remove db_constraint for prev_history (#102672)
0d20e6e 
This is part of the required steps to remove a column from Sentry:
https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns.

This is a follow-up to #102474.

This fixes [SENTRY-5BX8](https://sentry.sentry.io/issues/6994851757/)
and [SENTRY-5BXW](https://sentry.sentry.io/issues/6995699817/) which are
happening since we switched to the bulk deletion model (#102580).
shashjar pushed a commit that referenced this pull request Nov 4, 2025
@armenzg @shashjar
chore(grouphistory): Stop using prev_history (#102474)
453933b 
While investigating #102470, I realized we don't actually use it for
anything useful.

In order to delete the column, we first need to stop making use of it
(see
[docs](https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns)
for instructions).
shashjar pushed a commit that referenced this pull request Nov 4, 2025
@armenzg @shashjar
chore(group_history): Remove db_constraint for prev_history (#102672)
86d5021 
This is part of the required steps to remove a column from Sentry:
https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns.

This is a follow-up to #102474.

This fixes [SENTRY-5BX8](https://sentry.sentry.io/issues/6994851757/)
and [SENTRY-5BXW](https://sentry.sentry.io/issues/6995699817/) which are
happening since we switched to the bulk deletion model (#102580).
priscilawebdev pushed a commit that referenced this pull request Nov 6, 2025
@armenzg @priscilawebdev
chore(group_history): Remove db_constraint for prev_history (#102672)
827ca97 
This is part of the required steps to remove a column from Sentry:
https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns.

This is a follow-up to #102474.

This fixes [SENTRY-5BX8](https://sentry.sentry.io/issues/6994851757/)
and [SENTRY-5BXW](https://sentry.sentry.io/issues/6995699817/) which are
happening since we switched to the bulk deletion model (#102580).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cvxluo cvxluo cvxluo approved these changes

Assignees

@armenzg armenzg

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@armenzg @cvxluo