-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
chore(group_history): Remove db_constraint for prev_history #102672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of the required steps to remove a column from Sentry: https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns. This is a follow-up to #102474. This fixes [SENTRY-5BX8](https://sentry.sentry.io/issues/6994851757/) and [SENTRY-5BXW](https://sentry.sentry.io/issues/6995699817/) which are happening since we switched to the bulk deletion model (#102580).
armenzg
commented
Nov 4, 2025
| model_name="grouphistory", | ||
| name="prev_history", | ||
| field=sentry.db.models.fields.foreignkey.FlexibleForeignKey( | ||
| db_constraint=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This the modification.
|
This PR has a migration; here is the generated SQL for for --
-- Alter field prev_history on grouphistory
--
SET CONSTRAINTS "sentry_grouphistory_prev_history_id_905ec402_fk_sentry_gr" IMMEDIATE; ALTER TABLE "sentry_grouphistory" DROP CONSTRAINT "sentry_grouphistory_prev_history_id_905ec402_fk_sentry_gr"; |
armenzg
added a commit
that referenced
this pull request
Nov 4, 2025
This is part of the process of removing a column from Sentry: https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns This is a follow-up to #102672.
|
The migration drift failing is expected. |
cvxluo
approved these changes
Nov 4, 2025
shashjar
pushed a commit
that referenced
this pull request
Nov 4, 2025
This is part of the required steps to remove a column from Sentry: https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns. This is a follow-up to #102474. This fixes [SENTRY-5BX8](https://sentry.sentry.io/issues/6994851757/) and [SENTRY-5BXW](https://sentry.sentry.io/issues/6995699817/) which are happening since we switched to the bulk deletion model (#102580).
armenzg
added a commit
that referenced
this pull request
Nov 5, 2025
armenzg
added a commit
that referenced
this pull request
Nov 5, 2025
This is part of the process of removing a column from Sentry: https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns This is a follow-up to #102672.
armenzg
added a commit
that referenced
this pull request
Nov 5, 2025
This is part of the process of removing a column from Sentry: https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns This is a follow-up to #102672.
armenzg
added a commit
that referenced
this pull request
Nov 5, 2025
This is part of the process of removing a column from Sentry: https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns This is a follow-up to #102672.
priscilawebdev
pushed a commit
that referenced
this pull request
Nov 6, 2025
This is part of the required steps to remove a column from Sentry: https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns. This is a follow-up to #102474. This fixes [SENTRY-5BX8](https://sentry.sentry.io/issues/6994851757/) and [SENTRY-5BXW](https://sentry.sentry.io/issues/6995699817/) which are happening since we switched to the bulk deletion model (#102580).
priscilawebdev
pushed a commit
that referenced
this pull request
Nov 6, 2025
priscilawebdev
pushed a commit
that referenced
this pull request
Nov 6, 2025
This is part of the process of removing a column from Sentry: https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns This is a follow-up to #102672.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the required steps to remove a column from Sentry: https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns.
This is a follow-up to #102474.
This fixes SENTRY-5BX8 and SENTRY-5BXW which are happening since we switched to the bulk deletion model (#102580).
Next PR: #102788