-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(issues) Add skeleton for Org wide issues #11420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -754,7 +754,6 @@ function routes() { | |
| <Route path="/:orgId/" component={errorHandler(OrganizationDetails)}> | ||
| <Route component={errorHandler(OrganizationRoot)}> | ||
| <IndexRoute component={errorHandler(OrganizationDashboard)} /> | ||
|
|
||
| <Route | ||
| path="/organizations/:orgId/dashboards/" | ||
| componentPromise={() => | ||
|
|
@@ -767,7 +766,6 @@ function routes() { | |
| component={errorHandler(LazyLoad)} | ||
| /> | ||
| </Route> | ||
|
|
||
| <Route | ||
| path="/organizations/:orgId/discover/" | ||
| componentPromise={() => | ||
|
|
@@ -777,12 +775,10 @@ function routes() { | |
| <Redirect path="saved/" to="/organizations/:orgId/discover/" /> | ||
| <Route path="saved/:savedQueryId/" /> | ||
| </Route> | ||
|
|
||
| <Route | ||
| path="/organizations/:orgId/activity/" | ||
| component={errorHandler(OrganizationActivity)} | ||
| /> | ||
|
|
||
| <Route | ||
| path="/organizations/:orgId/events/" | ||
| componentPromise={() => | ||
|
|
@@ -795,14 +791,38 @@ function routes() { | |
| component={errorHandler(LazyLoad)} | ||
| /> | ||
| </Route> | ||
|
|
||
| <Route | ||
| path="/organizations/:orgId/issues/" | ||
| componentPromise={() => | ||
| import(/* webpackChunkName: "OrganizationStreamContainer" */ './views/organizationStream/container')} | ||
| component={errorHandler(LazyLoad)} | ||
| > | ||
| <IndexRoute | ||
| componentPromise={() => | ||
| import(/* webpackChunkName: "OrganizationStreamOverview" */ './views/organizationStream/overview')} | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the name is good - Is the stream something we'll want to keep codesplit once it's live on prod? We probably want it in the main bundle (and codesplit the older stream).
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah once org issues are out they should probably join the main bundle but for now I didn't want to bog down customers with code they won't use. I added APP-992 to track the removal of the code split. |
||
| component={errorHandler(LazyLoad)} | ||
| /> | ||
| </Route> | ||
| {/* Once org issues is complete, these routes can be nested under | ||
| /organizations/:orgId/issues */} | ||
| <Route | ||
| path="/organizations/:orgId/issues/assigned/" | ||
| component={errorHandler(MyIssuesAssignedToMe)} | ||
| /> | ||
| <Route | ||
| path="/organizations/:orgId/issues/bookmarks/" | ||
| component={errorHandler(MyIssuesBookmarked)} | ||
| /> | ||
| <Route | ||
| path="/organizations/:orgId/issues/history/" | ||
| component={errorHandler(MyIssuesViewed)} | ||
| /> | ||
| <Route | ||
| path="/organizations/:orgId/user-feedback/" | ||
| componentPromise={() => | ||
| import(/* webpackChunkName: "OrganizationUserFeedback" */ './views/userFeedback/organizationUserFeedback')} | ||
| component={errorHandler(LazyLoad)} | ||
| /> | ||
|
|
||
| <Route | ||
| path="/organizations/:orgId/releases/" | ||
| componentPromise={() => | ||
|
|
@@ -821,14 +841,12 @@ function routes() { | |
| component={errorHandler(LazyLoad)} | ||
| /> | ||
| </Route> | ||
|
|
||
| <Route | ||
| path="/organizations/:orgId/teams/new/" | ||
| componentPromise={() => | ||
| import(/* webpackChunkName: "TeamCreate" */ './views/teamCreate')} | ||
| component={errorHandler(LazyLoad)} | ||
| /> | ||
|
|
||
| <Route path="/organizations/:orgId/" component={OrganizationHomeContainer}> | ||
| <Redirect from="projects/" to="/:orgId/" /> | ||
| {hooksOrgRoutes} | ||
|
|
@@ -861,25 +879,10 @@ function routes() { | |
| <Redirect path="repos/" to="/settings/:orgId/repos/" /> | ||
| <Route path="stats/" component={errorHandler(OrganizationStats)} /> | ||
| </Route> | ||
|
|
||
| <Route | ||
| path="/organizations/:orgId/issues/assigned/" | ||
| component={errorHandler(MyIssuesAssignedToMe)} | ||
| /> | ||
| <Route | ||
| path="/organizations/:orgId/issues/bookmarks/" | ||
| component={errorHandler(MyIssuesBookmarked)} | ||
| /> | ||
| <Route | ||
| path="/organizations/:orgId/issues/history/" | ||
| component={errorHandler(MyIssuesViewed)} | ||
| /> | ||
|
|
||
| <Route | ||
| path="/organizations/:orgId/projects/new/" | ||
| component={errorHandler(NewProject)} | ||
| /> | ||
|
|
||
| <Route | ||
| path="/organizations/:orgId/projects/choose/" | ||
| component={errorHandler(ProjectChooser)} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import {withRouter} from 'react-router'; | ||
| import React from 'react'; | ||
|
|
||
| import {HeaderTitle, PageContent, PageHeader} from 'app/styles/organization'; | ||
| import {t} from 'app/locale'; | ||
| import Feature from 'app/components/acl/feature'; | ||
| import GlobalSelectionHeader from 'app/components/organizations/globalSelectionHeader'; | ||
| import SentryTypes from 'app/sentryTypes'; | ||
| import withOrganization from 'app/utils/withOrganization'; | ||
|
|
||
| class OrganizationStreamContainer extends React.Component { | ||
| static propTypes = { | ||
| organization: SentryTypes.Organization, | ||
| }; | ||
|
|
||
| render() { | ||
| const {organization, children} = this.props; | ||
|
|
||
| return ( | ||
| <Feature features={['sentry10']} renderDisabled> | ||
| <GlobalSelectionHeader organization={organization} /> | ||
|
|
||
| <PageContent> | ||
| <PageHeader> | ||
| <HeaderTitle>{t('Issues')}</HeaderTitle> | ||
| </PageHeader> | ||
|
|
||
| {children} | ||
| </PageContent> | ||
| </Feature> | ||
| ); | ||
| } | ||
| } | ||
| export default withRouter(withOrganization(OrganizationStreamContainer)); | ||
| export {OrganizationStreamContainer}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier doing its thing 🤷♂️