feat(issues) Add skeleton for Org wide issues #11420
Conversation
Its a place to start. I wanted to get feedback on the name `organizationStream`. At a high level I was thinking of duplicating most of the stream components as there are subtle shifts in requirements like: * Bulk operations will only work if issues from a single project are selected. * Search context comes from both the global filter bar and other search controls. * Saved Searches come from different endpoints and behave differently in the search query input. I've added a few placeholder components that I plan on replacing individually as the APIs for them become available. Notably absent from these changes are saved searches and processing issues which will be added later as they have their own tasks in Jira. Refs APP-990
| path="/organizations/:orgId/activity/" | ||
| component={errorHandler(OrganizationActivity)} | ||
| /> | ||
|
|
There was a problem hiding this comment.
Prettier doing its thing 🤷♂️
| component={errorHandler(LazyLoad)} | ||
| /> | ||
| </Route> | ||
| /* Once org issues is complete, these routes can be nested under |
There was a problem hiding this comment.
Is this a valid comment? Doesn't it need {}?
| > | ||
| <IndexRoute | ||
| componentPromise={() => | ||
| import(/* webpackChunkName: "OrganizationStreamOverview" */ './views/organizationStream/overview')} |
There was a problem hiding this comment.
I think the name is good - Is the stream something we'll want to keep codesplit once it's live on prod? We probably want it in the main bundle (and codesplit the older stream).
There was a problem hiding this comment.
Yeah once org issues are out they should probably join the main bundle but for now I didn't want to bog down customers with code they won't use. I added APP-992 to track the removal of the code split.
I've removed the projectId prop as it wasn't necessary and could be fetched from the GroupStore. This allows the StreamGroup to be used wholesale in both the org and project stream.
There was a problem hiding this comment.
Assume this is mostly copied from the stream component, might be nice though not essential to share some of the code since this may be around for a while. I think the environments stuff might need to be changed since the way we handle that now in the org views (global selection store) is different from how environment filtering worked in the project specific views
|
@lynnagara The differences in how environment parameters work is making me think that a copy is going to be better for this page and the search/bulk actions. |
Environments in the org issue stream come from reflux not props/query string.
* master: (56 commits) feat(issues) Add skeleton for Org wide issues (#11420) fix(api): Fix broken spam email blocking code don't need this white background anymore and it causes a bug on hosted setup (#11436) fix(charts): Fix max value for WorldMapChart (#11404) feat(issues): Add issues icon to sidebar (#11439) build: Remove 'exports' from sourcemaps sources prefix (#11438) fix: Render integration description as markdown in search (#11441) ref: Import jquery when it's used (#11430) fix(ui): Render message params (#11432) ref(releases): Refactor projects/organization release overview (#11392) ref(groups): Refactor project group details (#11422) feat(2fa): Allow org to reset member 2fa (#11152) feat(api): Add relative stats period support to get_date_range_from_params (#11380) chore: Remove group-unmerge flag (#11431) fix(ui) Fix 'other' tag bucket to have a proper tooltip (#11433) build(dev): Add `yarn dev` script to start sentry devserver (#11360) ref(charts): Change PercentageBarChart -> PercentageAreaChart (#11401) feat(discover): Zerofill queries that are grouped by time (#11384) test: Add coverage for breadcrumb message scrubbing feat(releases): Add all organization release routes (#11377) ...
Its a place to start. I wanted to get feedback on the name
organizationStream.At a high level I was thinking of duplicating most of the stream components as there are subtle shifts in requirements like:
I've added a few placeholder components that I plan on replacing individually as the APIs for them become available. Notably absent from these changes are saved searches and processing issues which will be added later as they have their own tasks in Jira.
Refs APP-990