feat(api): Add relative stats period support to get_date_range_from_params #11380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynnagara
added a commit
that referenced
this pull request
Jan 7, 2019
Extract common components and functions from the organization and project release overview pages. Depends on #11380
wedamija
approved these changes
Jan 7, 2019
src/sentry/api/utils.py
Outdated
| delta = end - start | ||
| if delta < MIN_STATS_PERIOD or delta > MAX_STATS_PERIOD: | ||
| raise InvalidParams( | ||
| 'Time window must be greater than an hour and less than or equal to 90 days') |
Member
There was a problem hiding this comment.
Might make sense to make this string dynamic so that it doesn't break if we change min/max period
| assert end is None | ||
|
|
||
| @freeze_time('2018-12-11 03:21:34') | ||
| def test_relative_date_range(self): |
Member
There was a problem hiding this comment.
Could be worth testing having statsPeriod(Start|End) missing
lynnagara
added a commit
that referenced
this pull request
Jan 8, 2019
Extract common components and functions from the organization and project release overview pages. Depends on #11380
macqueen
force-pushed
the
feat-relative-date-ranges-api
branch
from
aac8851 to
f85c5fc
Compare
lynnagara
added a commit
that referenced
this pull request
Jan 9, 2019
Extract common components and functions from the organization and project release overview pages. Depends on #11380
lynnagara
added a commit
that referenced
this pull request
Jan 9, 2019
Extract common components and functions from the organization and project release overview pages. Depends on #11380
jan-auer
added a commit
that referenced
this pull request
Jan 10, 2019
* master: (56 commits) feat(issues) Add skeleton for Org wide issues (#11420) fix(api): Fix broken spam email blocking code don't need this white background anymore and it causes a bug on hosted setup (#11436) fix(charts): Fix max value for WorldMapChart (#11404) feat(issues): Add issues icon to sidebar (#11439) build: Remove 'exports' from sourcemaps sources prefix (#11438) fix: Render integration description as markdown in search (#11441) ref: Import jquery when it's used (#11430) fix(ui): Render message params (#11432) ref(releases): Refactor projects/organization release overview (#11392) ref(groups): Refactor project group details (#11422) feat(2fa): Allow org to reset member 2fa (#11152) feat(api): Add relative stats period support to get_date_range_from_params (#11380) chore: Remove group-unmerge flag (#11431) fix(ui) Fix 'other' tag bucket to have a proper tooltip (#11433) build(dev): Add `yarn dev` script to start sentry devserver (#11360) ref(charts): Change PercentageBarChart -> PercentageAreaChart (#11401) feat(discover): Zerofill queries that are grouped by time (#11384) test: Add coverage for breadcrumb message scrubbing feat(releases): Add all organization release routes (#11377) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
going to refactor the discover endpoint to use this too (since that's where @billyvg needs it)