feat(2fa): Allow org to reset member 2fa #11152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Jan 2, 2019
| attrs[item]['permissions'] = permissions[item.id] | ||
|
|
||
| # org can reset 2FA if the user is only in one org | ||
| attrs[item]['canReset2fa'] = len(memberships[item.id]) == 1 |
Member
There was a problem hiding this comment.
How do users with more than one org get this flag to be true? Should it be true if the user is viewing themself?
Contributor
Author
There was a problem hiding this comment.
Hm I went with no, the user shouldn't be able to reset their 2FA from this page. I think users can only read the member details page, but it takes manager and up permissions to take any action. Thought it would be more consistent to keep this page for managing members, since users can remove their 2FA in user settings. What do you think?
billyvg
reviewed
Jan 4, 2019
src/sentry/static/sentry/app/views/settings/organizationMembers/organizationMemberDetail.jsx
Outdated
Show resolved
Hide resolved
src/sentry/static/sentry/app/views/settings/organizationMembers/organizationMemberDetail.jsx
Outdated
Show resolved
Hide resolved
src/sentry/static/sentry/app/views/settings/organizationMembers/organizationMemberDetail.jsx
Outdated
Show resolved
Hide resolved
maheskett
force-pushed
the
maheskett/owner-reset-2fa
branch
from
920c9b9 to
e920797
Compare
Contributor
Author
|
@markstory is this good on your end? |
markstory
approved these changes
Jan 9, 2019
jan-auer
added a commit
that referenced
this pull request
Jan 10, 2019
* master: (56 commits) feat(issues) Add skeleton for Org wide issues (#11420) fix(api): Fix broken spam email blocking code don't need this white background anymore and it causes a bug on hosted setup (#11436) fix(charts): Fix max value for WorldMapChart (#11404) feat(issues): Add issues icon to sidebar (#11439) build: Remove 'exports' from sourcemaps sources prefix (#11438) fix: Render integration description as markdown in search (#11441) ref: Import jquery when it's used (#11430) fix(ui): Render message params (#11432) ref(releases): Refactor projects/organization release overview (#11392) ref(groups): Refactor project group details (#11422) feat(2fa): Allow org to reset member 2fa (#11152) feat(api): Add relative stats period support to get_date_range_from_params (#11380) chore: Remove group-unmerge flag (#11431) fix(ui) Fix 'other' tag bucket to have a proper tooltip (#11433) build(dev): Add `yarn dev` script to start sentry devserver (#11360) ref(charts): Change PercentageBarChart -> PercentageAreaChart (#11401) feat(discover): Zerofill queries that are grouped by time (#11384) test: Add coverage for breadcrumb message scrubbing feat(releases): Add all organization release routes (#11377) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows 'member:admin' to reset an org member's 2FA, if the member is only in one org and 2FA isn't required.