fix(sidebar): optically align active indicator #11603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Chrissy
commented
Jan 18, 2019
Chrissy
commented
Contributor
Author
|
the percy results are funny on this one—I guess it can't display diffs that are sub two pixels. |
billyvg
approved these changes
Jan 18, 2019
Member
billyvg
left a comment
billyvg
left a comment
There was a problem hiding this comment.
Yeah kind of odd that percy isn't showing diffs, maybe it is centered in firefox?
Contributor
Author
|
I don't think so because then percy wouldn't register the diff at all, right? the diffs are definitely coming through, but there is no red. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.