Skip to content

fix(sidebar): optically align active indicator #11603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chrissy merged 2 commits into from
Jan 18, 2019
Merged

fix(sidebar): optically align active indicator #11603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44b8878
optically align active indicator
Chrissy Jan 18, 2019
faebe22
set to same size as typical icon
Chrissy Jan 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/sentry/static/sentry/app/components/sidebar/sidebarItem.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,9 @@ const StyledSidebarItem = styled(({active, ...props}) => <Link {...props} />)`
display: block;
content: '';
position: absolute;
top: 5px;
top: 4px;
left: -20px;
bottom: 5px;
bottom: 6px;
width: 5px;
border-radius: 0 3px 3px 0;
background-color: transparent;
Expand Down
60 changes: 30 additions & 30 deletions tests/js/spec/views/__snapshots__/organizationsDetails.spec.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ exports[`OrganizationDetails render() deletion in progress should render a delet
class="css-tlukoq-SidebarSectionGroup-responsiveFlex-SidebarSection e1sgxx352"
>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -114,7 +114,7 @@ exports[`OrganizationDetails render() deletion in progress should render a delet
class="css-tlukoq-SidebarSectionGroup-responsiveFlex-SidebarSection e1sgxx352"
>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -145,7 +145,7 @@ exports[`OrganizationDetails render() deletion in progress should render a delet
</div>
</a>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -176,7 +176,7 @@ exports[`OrganizationDetails render() deletion in progress should render a delet
</div>
</a>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -211,7 +211,7 @@ exports[`OrganizationDetails render() deletion in progress should render a delet
class="css-tlukoq-SidebarSectionGroup-responsiveFlex-SidebarSection e1sgxx352"
>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -242,7 +242,7 @@ exports[`OrganizationDetails render() deletion in progress should render a delet
</div>
</a>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -277,7 +277,7 @@ exports[`OrganizationDetails render() deletion in progress should render a delet
class="css-tlukoq-SidebarSectionGroup-responsiveFlex-SidebarSection e1sgxx352"
>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -324,7 +324,7 @@ exports[`OrganizationDetails render() deletion in progress should render a delet
tabindex="-1"
>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -357,7 +357,7 @@ exports[`OrganizationDetails render() deletion in progress should render a delet
</div>
</div>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
data-test-id="sidebar-broadcasts"
>
<div
Expand Down Expand Up @@ -396,7 +396,7 @@ exports[`OrganizationDetails render() deletion in progress should render a delet
class="css-tlukoq-SidebarSectionGroup-responsiveFlex-SidebarSection e1sgxx352"
>
<a
class="e1sgxx354 css-7c155y-StyledSidebarItem-SidebarCollapseItem e1qdnaq70"
class="e1sgxx354 css-ekfpov-StyledSidebarItem-SidebarCollapseItem e1qdnaq70"
data-test-id="sidebar-collapse"
>
<div
Expand Down Expand Up @@ -555,7 +555,7 @@ exports[`OrganizationDetails render() pending deletion should render a restorati
class="css-tlukoq-SidebarSectionGroup-responsiveFlex-SidebarSection e1sgxx352"
>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -590,7 +590,7 @@ exports[`OrganizationDetails render() pending deletion should render a restorati
class="css-tlukoq-SidebarSectionGroup-responsiveFlex-SidebarSection e1sgxx352"
>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -621,7 +621,7 @@ exports[`OrganizationDetails render() pending deletion should render a restorati
</div>
</a>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -652,7 +652,7 @@ exports[`OrganizationDetails render() pending deletion should render a restorati
</div>
</a>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -687,7 +687,7 @@ exports[`OrganizationDetails render() pending deletion should render a restorati
class="css-tlukoq-SidebarSectionGroup-responsiveFlex-SidebarSection e1sgxx352"
>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -718,7 +718,7 @@ exports[`OrganizationDetails render() pending deletion should render a restorati
</div>
</a>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -753,7 +753,7 @@ exports[`OrganizationDetails render() pending deletion should render a restorati
class="css-tlukoq-SidebarSectionGroup-responsiveFlex-SidebarSection e1sgxx352"
>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -800,7 +800,7 @@ exports[`OrganizationDetails render() pending deletion should render a restorati
tabindex="-1"
>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -833,7 +833,7 @@ exports[`OrganizationDetails render() pending deletion should render a restorati
</div>
</div>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
data-test-id="sidebar-broadcasts"
>
<div
Expand Down Expand Up @@ -872,7 +872,7 @@ exports[`OrganizationDetails render() pending deletion should render a restorati
class="css-tlukoq-SidebarSectionGroup-responsiveFlex-SidebarSection e1sgxx352"
>
<a
class="e1sgxx354 css-7c155y-StyledSidebarItem-SidebarCollapseItem e1qdnaq70"
class="e1sgxx354 css-ekfpov-StyledSidebarItem-SidebarCollapseItem e1qdnaq70"
data-test-id="sidebar-collapse"
>
<div
Expand Down Expand Up @@ -1058,7 +1058,7 @@ exports[`OrganizationDetails render() pending deletion should render a restorati
class="css-tlukoq-SidebarSectionGroup-responsiveFlex-SidebarSection e1sgxx352"
>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -1093,7 +1093,7 @@ exports[`OrganizationDetails render() pending deletion should render a restorati
class="css-tlukoq-SidebarSectionGroup-responsiveFlex-SidebarSection e1sgxx352"
>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -1124,7 +1124,7 @@ exports[`OrganizationDetails render() pending deletion should render a restorati
</div>
</a>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -1155,7 +1155,7 @@ exports[`OrganizationDetails render() pending deletion should render a restorati
</div>
</a>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -1190,7 +1190,7 @@ exports[`OrganizationDetails render() pending deletion should render a restorati
class="css-tlukoq-SidebarSectionGroup-responsiveFlex-SidebarSection e1sgxx352"
>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -1221,7 +1221,7 @@ exports[`OrganizationDetails render() pending deletion should render a restorati
</div>
</a>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -1256,7 +1256,7 @@ exports[`OrganizationDetails render() pending deletion should render a restorati
class="css-tlukoq-SidebarSectionGroup-responsiveFlex-SidebarSection e1sgxx352"
>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -1303,7 +1303,7 @@ exports[`OrganizationDetails render() pending deletion should render a restorati
tabindex="-1"
>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
>
<div
class="css-gn87gt-SidebarItemWrapper e1qdnaq71"
Expand Down Expand Up @@ -1336,7 +1336,7 @@ exports[`OrganizationDetails render() pending deletion should render a restorati
</div>
</div>
<a
class="css-1l9toro-StyledSidebarItem e1qdnaq70"
class="css-u8cmbr-StyledSidebarItem e1qdnaq70"
data-test-id="sidebar-broadcasts"
>
<div
Expand Down Expand Up @@ -1375,7 +1375,7 @@ exports[`OrganizationDetails render() pending deletion should render a restorati
class="css-tlukoq-SidebarSectionGroup-responsiveFlex-SidebarSection e1sgxx352"
>
<a
class="e1sgxx354 css-7c155y-StyledSidebarItem-SidebarCollapseItem e1qdnaq70"
class="e1sgxx354 css-ekfpov-StyledSidebarItem-SidebarCollapseItem e1qdnaq70"
data-test-id="sidebar-collapse"
>
<div
Expand Down