fix(similarity): Use interface attribute that exists #12137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was probably broken with GH-11078 but it's hard to tell for sure because the logger is disabled that reports feature extraction failure. This only really presents itself as a failure in development when bootstrapping an environment with `bin/load-mocks`.
tkaemming
commented
Feb 20, 2019
| lambda message: text_shingle( | ||
| 5, | ||
| message.message, | ||
| message.formatted, |
Contributor
Author
There was a problem hiding this comment.
"generally interfaces shouldn't change" / "just use the attribute and move on"
Contributor
Author
There was a problem hiding this comment.
Also worth noting for future me that this doesn't really work the same way (interpolated messages will have higher cardinality going into the feature set, so probably cause more Redis issues) but I don't care enough to drag this out
mattrobenolt
approved these changes
Feb 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was probably broken with GH-11078 but it's hard to tell for sure
because the logger is disabled that reports feature extraction failure.
This only really presents itself as a failure in development when
bootstrapping an environment with
bin/load-mocks.