Skip to content

fix(similarity): Use interface attribute that exists #12137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkaemming merged 1 commit into from
Feb 20, 2019
Merged

fix(similarity): Use interface attribute that exists #12137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/similarity/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def _make_index_backend(cluster=None):
'message:message:character-shingles': MessageFeature(
lambda message: text_shingle(
5,
message.message,
message.formatted,
Copy link
Contributor Author

@tkaemming tkaemming Feb 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"generally interfaces shouldn't change" / "just use the attribute and move on"

Copy link
Contributor Author

@tkaemming tkaemming Feb 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also worth noting for future me that this doesn't really work the same way (interpolated messages will have higher cardinality going into the feature set, so probably cause more Redis issues) but I don't care enough to drag this out

),
),
},
Expand Down