Skip to content

meta(vscode): Do not autoformat Django templates #12350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

lynnagara
Copy link
Member

No description provided.

@lynnagara lynnagara requested a review from a team March 8, 2019 20:46
@billyvg
Copy link
Member

billyvg commented Mar 8, 2019

Can we add this to the prettier ignore dotfile instead so that it applies to all editors?

@lynnagara
Copy link
Member Author

We don't have a prettier ignore file right now - is that something we want to add? I still think we can add this since formatOnSave settings for other file types in vscode are all specified in this way right now

Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think we should add a .prettierignore since that'll help other editors as well

@lynnagara lynnagara merged commit 3c66410 into master Mar 11, 2019
@lynnagara lynnagara deleted the meta/do-not-format-django-templates branch March 11, 2019 22:15
jan-auer added a commit that referenced this pull request Mar 12, 2019
* master:
  fix(ui) Fix short-id overlap on issue details (#12343)
  fix(ui) Going to a global saved search from a project based one (#12358)
  feat(hooks): Add named hooks to events / discover Features (#12365)
  test(ui): Add test for LazyLoad props change (#12366)
  test(js): Update snapshots from Button changes (#12371)
  fix(tags): Remove timestamp tag support from issue stream (#12353)
  meta(vscode): Do not autoformat Django templates (#12350)
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants