fix(ui) Going to a global saved search from a project based one #12358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going from a project based saved search to a global one should retain the current global search so that users without global views don't get a backend error. Fixes SEN-251
billyvg
approved these changes
Mar 11, 2019
src/sentry/static/sentry/app/views/organizationStream/overview.jsx
Outdated
Show resolved
Hide resolved
| } else { | ||
| path = `/organizations/${organization.slug}/issues/`; | ||
| } | ||
|
|
||
| if (path !== this.props.location.path && !isEqual(query, this.props.location.query)) { | ||
| // TODO: Delete/revert this after testing production counts cc/ @wedamija | ||
| if (this.props.location.query[NEW_FILTERS_TEST]) { |
There was a problem hiding this comment.
There should be other code that needs to be removed in this file iirc
….jsx Co-Authored-By: markstory <mark@mark-story.com>
jan-auer
added a commit
that referenced
this pull request
Mar 12, 2019
* master: fix(ui) Fix short-id overlap on issue details (#12343) fix(ui) Going to a global saved search from a project based one (#12358) feat(hooks): Add named hooks to events / discover Features (#12365) test(ui): Add test for LazyLoad props change (#12366) test(js): Update snapshots from Button changes (#12371) fix(tags): Remove timestamp tag support from issue stream (#12353) meta(vscode): Do not autoformat Django templates (#12350)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going from a project based saved search to a global one should retain the current global search so that users without global views don't get a backend error.
Fixes SEN-251