feat(app-platform): Analytics #12718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class SentryAppDeletedEvent(analytics.Event): | ||
| type = 'sentry_app.deleted' | ||
|
|
||
| attributes = ( |
There was a problem hiding this comment.
is there a reason we don't want the organization_id for this event? (for update app as well)
There was a problem hiding this comment.
We can derive the Org from the SentryApp, so I figured we didn't need it here.
| @@ -58,6 +60,8 @@ def _create_sentry_app(self): | |||
| overview=self.overview, | |||
| ) | |||
|
|
|||
| return self.sentry_app | |||
There was a problem hiding this comment.
I don't think you need this because we already have self.app, maybe its worth changing that to be self.sentry_app?
Adds analytics recording for a set of events: - Sentry App Created - Sentry App Updated - Sentry App Deleted - Sentry App Installed - Sentry App Uninstalled - Sentry App Token Exchanged (authorize) - Sentry App Token Exchanged (refresh)
mnoble
force-pushed
the
app-platform/analytics
branch
from
f2ec612 to
1909357
Compare
MeredithAnya
approved these changes
Apr 15, 2019
jan-auer
added a commit
that referenced
this pull request
Apr 16, 2019
* master: (50 commits) fix(ui) Don't show save-org-search on event search (#12785) ref(ui): Remove some unnecessary index.jsx files (#12606) feat(app-platform): Analytics (#12718) ref(js): Remove ApiMixin (#12384) test(js): Silence project plugin console info spam (#12761) test(js): Move SaveSearchStore.reset() (#12769) test(js): Add more fields to Group fixture (#12759) feat(app-platform): Integration "Learn More" modal (#12638) feat(saved-searches) Move create saved search button to search bar. (#12781) ref(global-header): Remove dead code (#12767) ref(releases): Refactored Releases Serializers (#12535) feat(app-platform): Sort Integrations (#12697) ref(audit-log): Log sso config updates (#12744) ref(app-platform): New 'Open In' UI (#12621) feat(events): Use SnubaEvent if option is turned on (#12594) feat(global-selection-header): show settings icon link in single project mode (#12772) refs(api): Consolidate all search backend code into `SnubaSearchBackend` fix(tests) Remove large snapshots (#12766) fix: Update symbolicator snapshots (#12710) ref: Upgrade semaphore (#12751) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds analytics recording for a set of events: