ref(global-header): Remove dead code #12767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark prop as required. Since this.props.projects is never falsy, remove unused code path
billyvg
reviewed
Apr 12, 2019
| @@ -302,14 +302,13 @@ class GlobalSelectionHeader extends React.Component { | |||
|
|
|||
| getProjects = () => { | |||
| const {isSuperuser} = ConfigStore.get('user'); | |||
| const {projects, organization} = this.props; | |||
| const unfilteredProjects = projects || organization.projects; | |||
There was a problem hiding this comment.
@Chrissy I seem to recall this being here for a reason, do you remember why?
There was a problem hiding this comment.
It's probably a relic of before the component was wrapped in withProjects
There was a problem hiding this comment.
Here is the commit that introduced the behavior 109ba9c
There was a problem hiding this comment.
yeah afaik this is a relic. there is similar looking code in projectSelector that is important because it can either receive projects as a prop or get it from the state, but this is not that.
billyvg
approved these changes
Apr 15, 2019
jan-auer
added a commit
that referenced
this pull request
Apr 16, 2019
* master: (50 commits) fix(ui) Don't show save-org-search on event search (#12785) ref(ui): Remove some unnecessary index.jsx files (#12606) feat(app-platform): Analytics (#12718) ref(js): Remove ApiMixin (#12384) test(js): Silence project plugin console info spam (#12761) test(js): Move SaveSearchStore.reset() (#12769) test(js): Add more fields to Group fixture (#12759) feat(app-platform): Integration "Learn More" modal (#12638) feat(saved-searches) Move create saved search button to search bar. (#12781) ref(global-header): Remove dead code (#12767) ref(releases): Refactored Releases Serializers (#12535) feat(app-platform): Sort Integrations (#12697) ref(audit-log): Log sso config updates (#12744) ref(app-platform): New 'Open In' UI (#12621) feat(events): Use SnubaEvent if option is turned on (#12594) feat(global-selection-header): show settings icon link in single project mode (#12772) refs(api): Consolidate all search backend code into `SnubaSearchBackend` fix(tests) Remove large snapshots (#12766) fix: Update symbolicator snapshots (#12710) ref: Upgrade semaphore (#12751) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark prop as required. Since this.props.projects is never falsy, remove
unused code path