feat(events-v2) Add pagination controls to event modal #13610
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In grouped views we want to show pagination buttons to navigate between the events that match the current search filters including the query string. By creating URLs that use eventSlug and the current search criteria we'll end up at the right events. Refs SEN-715
lynnagara
reviewed
Jun 10, 2019
| browserHistory.goBack(); | ||
| const {location} = this.props; | ||
| // Remove modal related query parameters. | ||
| const query = omit(location.query, ['groupId', 'eventSlug', 'oldest']); |
There was a problem hiding this comment.
Could "oldest" and "latest" just be handled as special cases of eventSlug values? This is similar how it's handled in the issue details views where "oldest" and "latest" are just special eventIds that are handled a bit differently. I think the nice thing about it is that we avoid two additional URL params.
There was a problem hiding this comment.
Sure. I like that idea. 👍
|
Closing this and joining it into #13568 so the chart and pagination can be reviewed as one piece. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In grouped views we want to show pagination buttons to navigate between the events that match the current search filters including the query string. By creating URLs that use eventSlug and the current search criteria we'll end up at the right events.
The mocks include a 'showing event x of y' section. We currently don't have a way to get this data, and getting the total number of events that match the current query will likely not perform well.
Refs SEN-715