Skip to content

feat(events-v2) Add pagination controls to event modal #13610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/sentry/static/sentry/app/icons/icon-next.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions src/sentry/static/sentry/app/icons/icon-prev.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ import React from 'react';
import styled from 'react-emotion';
import {browserHistory} from 'react-router';
import PropTypes from 'prop-types';
import SentryTypes from 'app/sentryTypes';
import {omit} from 'lodash';

import SentryTypes from 'app/sentryTypes';
import AsyncComponent from 'app/components/asyncComponent';
import InlineSvg from 'app/components/inlineSvg';
import withApi from 'app/utils/withApi';
Expand Down Expand Up @@ -41,15 +42,12 @@ class EventDetails extends AsyncComponent {
query.query = `issue.id:${groupId}`;
}

return [
[
'event',
`/organizations/${organization.slug}/events/latest/`,
{
query,
},
],
];
let path = `/organizations/${organization.slug}/events/latest/`;
if (location.query.oldest) {
path = `/organizations/${organization.slug}/events/oldest/`;
}

return [['event', path, {query}]];
}

// Get a specific event. This could be coming from
Expand All @@ -67,7 +65,14 @@ class EventDetails extends AsyncComponent {

handleClose = event => {
event.preventDefault();
browserHistory.goBack();
const {location} = this.props;
// Remove modal related query parameters.
const query = omit(location.query, ['groupId', 'eventSlug', 'oldest']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could "oldest" and "latest" just be handled as special cases of eventSlug values? This is similar how it's handled in the issue details views where "oldest" and "latest" are just special eventIds that are handled a bit differently. I think the nice thing about it is that we avoid two additional URL params.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I like that idea. 👍


browserHistory.push({
pathname: location.pathname,
query,
});
};

handleTabChange = tab => this.setState({activeTab: tab});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import utils from 'app/utils';
import {getMessage, getTitle} from 'app/utils/events';

import {INTERFACES} from 'app/components/events/eventEntries';
import ModalPagination from './modalPagination';
import ModalLineGraph from './modalLineGraph';
import TagsTable from './tagsTable';
import LinkedIssuePreview from './linkedIssuePreview';
Expand Down Expand Up @@ -87,6 +88,9 @@ const EventModalContent = props => {
<ColumnGrid>
<HeaderBox>
<EventHeader event={event} />
{isGroupedView && (
<ModalPagination event={event} location={location} groupId={event.groupId} />
)}
{isGroupedView &&
getDynamicText({
value: (
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
import React from 'react';
import PropTypes from 'prop-types';
import styled from 'react-emotion';
import {omit} from 'lodash';

import {t} from 'app/locale';
import Link from 'app/components/links/link';
import SentryTypes from 'app/sentryTypes';
import InlineSvg from 'app/components/inlineSvg';
import space from 'app/styles/space';

const ModalPagination = props => {
const {location, event} = props;

// Remove the groupId and eventSlug keys as we need to create new ones
const query = omit(location.query, ['groupId', 'eventSlug', 'oldest']);
const previousEventUrl = event.previousEventID
? {
pathname: location.pathname,
query: {
...query,
eventSlug: `${event.projectSlug}:${event.previousEventID}`,
},
}
: null;
const nextEventUrl = event.nextEventID
? {
pathname: location.pathname,
query: {
...query,
eventSlug: `${event.projectSlug}:${event.nextEventID}`,
},
}
: null;
const newestUrl = {
pathname: location.pathname,
query: {
...query,
groupId: event.groupID,
},
};
const oldestUrl = {
pathname: location.pathname,
query: {
...query,
oldest: 1,
groupId: event.groupID,
},
};

return (
<Wrapper>
<Container>
<StyledLink to={oldestUrl}>
<InlineSvg src="icon-prev" size="14px" />
</StyledLink>
<StyledLink to={previousEventUrl} disabled={previousEventUrl === null}>
{t('Older Event')}
</StyledLink>
<StyledLink to={nextEventUrl} disabled={nextEventUrl === null}>
{t('Newer Event')}
</StyledLink>
<StyledLink to={newestUrl} last>
<InlineSvg src="icon-next" size="14px" />
</StyledLink>
</Container>
</Wrapper>
);
};
ModalPagination.propTypes = {
location: PropTypes.object.isRequired,
event: SentryTypes.Event.isRequired,
};

const StyledLink = styled(Link)`
color: ${p => (p.disabled ? p.theme.disabled : p.theme.gray3)};
font-size: ${p => p.fontSizeMedium};
padding: ${space(0.5)} ${space(1.5)};
${p => (p.last ? '' : `border-right: 1px solid ${p.theme.borderDark};`)}
${p => (p.disabled ? 'pointer-events: none;' : '')}
`;

const Wrapper = styled('div')`
display: flex;
`;

const Container = styled('div')`
display: flex;
background: ${p => p.theme.offWhite};
border: 1px solid ${p => p.theme.borderDark};
border-radius: ${p => p.theme.borderRadius};
margin-bottom: ${space(3)};
box-shadow: 3px 3px 0 ${p => p.theme.offWhite}, 3px 3px 0 1px ${p => p.theme.borderDark},
7px 7px ${p => p.theme.offWhite}, 7px 7px 0 1px ${p => p.theme.borderDark};
`;

export default ModalPagination;
26 changes: 23 additions & 3 deletions tests/js/spec/views/organizationEventsV2/eventDetails.spec.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -115,19 +115,39 @@ describe('OrganizationEventsV2 > EventDetails', function() {
expect(graph).toHaveLength(1);
});

it('goes back when close button is clicked', function() {
it('renders pagination buttons in grouped view', function() {
const wrapper = mount(
<EventDetails
organization={TestStubs.Organization({projects: [TestStubs.Project()]})}
groupId="123"
location={{query: {groupId: '999'}}}
view={errorsView}
/>,
TestStubs.routerContext()
);
const content = wrapper.find('ModalPagination');
expect(content).toHaveLength(1);
});

it('changes history when close button is clicked', function() {
const wrapper = mount(
<EventDetails
organization={TestStubs.Organization({projects: [TestStubs.Project()]})}
eventSlug="project-slug:deadbeef"
location={{query: {eventSlug: 'project-slug:deadbeef'}}}
location={{
pathname: '/organizations/org-slug/events/',
query: {eventSlug: 'project-slug:deadbeef'},
}}
view={allEventsView}
/>,
TestStubs.routerContext()
);
const button = wrapper.find('CloseButton');
button.simulate('click');
expect(browserHistory.goBack).toHaveBeenCalled();
expect(browserHistory.push).toHaveBeenCalledWith({
pathname: '/organizations/org-slug/events/',
query: {},
});
});

it('navigates when tag values are clicked', async function() {
Expand Down