Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(onobarding): Remove old onboarding experience #14066

Conversation

evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented Jul 17, 2019

This completely removes the old onboarding experience and makes the new
onboarding experience the default.

Requires https://github.com/getsentry/getsentry/pull/3058

@evanpurkhiser evanpurkhiser requested review from adhiraj, maheskett and a team July 17, 2019 22:37
Copy link
Contributor

@adhiraj adhiraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls look at tests and percy snapshots (just approving without review in case you wanna get unblocked)

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/refonobarding-remove-old-onboarding-experience branch from dcfb342 to 70e1bb1 Compare July 17, 2019 23:05
@evanpurkhiser
Copy link
Member Author

Percy snapshots should reflect the new onboarding. Yes I will look.

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/refonobarding-remove-old-onboarding-experience branch from 70e1bb1 to a228da1 Compare July 17, 2019 23:15
@evanpurkhiser evanpurkhiser added the Do Not Merge Don't merge label Jul 17, 2019
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/refonobarding-remove-old-onboarding-experience branch from a228da1 to 6581a1d Compare July 17, 2019 23:45
@evanpurkhiser evanpurkhiser removed the Do Not Merge Don't merge label Jul 20, 2019
@evanpurkhiser evanpurkhiser merged commit d6f3fc6 into master Jul 22, 2019
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/refonobarding-remove-old-onboarding-experience branch July 22, 2019 17:11
HazAT added a commit that referenced this pull request Jul 23, 2019
* master: (25 commits)
  ref(onboarding): Fix install promprt URL (#14106)
  fix(app-platform): Allow GET requests for published apps (#14109)
  feat: Update Group.get_latest_event to use Snuba event (#14039)
  ref(onboarding): Rename wizardNew -> onboarding (#14104)
  feat(apm): Update props to address proptype warnings for new transaction attributes (SEN-800) (#14040)
  ref(ui): Move and codesplit `ProjectPlugins` (#13952)
  feat(typescript): Add TypeScript compatibility (#13786)
  ref(templates): Remove unused content block default (#14090)
  ref(less): Remove unused admin.less (#14097)
  ref(onobarding): Remove old onboarding experience (#14066)
  fix(ui) Fix missing conditions in tag bars (#14063)
  ref(suspect-commits): Add hook (#14057)
  ref(frontend): Segment frontend web urls (#14096)
  feat(suspect-commits): Add analytics events (#14080)
  feat(servicehooks): Update servicehook URLs (#14093)
  license: Remove license headers (#14095)
  ref(templates): Remove unused account_nav (#14091)
  fix: Disable transaction events in store (#14088)
  fix(InstallWizard): Fix exception when InstallWizard completed (#14092)
  ref(admin): Fix thrashing on stat charts (#14094)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants