fix(app-platform): Allow GET requests for published apps #14109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/sentry/api/bases/sentryapps.py
Outdated
| @@ -160,6 +160,11 @@ def has_object_permission(self, request, view, sentry_app): | |||
| if sentry_app.owner not in request.user.get_orgs(): | |||
| raise Http404 | |||
|
|
|||
| # we can't use ensure_scoped_permission now that the public | |||
| # endpoint isn't denoted by '()' | |||
There was a problem hiding this comment.
Can you make it into a TODO?
evanpurkhiser
approved these changes
Jul 22, 2019
wedamija
approved these changes
Jul 22, 2019
HazAT
added a commit
that referenced
this pull request
Jul 23, 2019
* master: (25 commits) ref(onboarding): Fix install promprt URL (#14106) fix(app-platform): Allow GET requests for published apps (#14109) feat: Update Group.get_latest_event to use Snuba event (#14039) ref(onboarding): Rename wizardNew -> onboarding (#14104) feat(apm): Update props to address proptype warnings for new transaction attributes (SEN-800) (#14040) ref(ui): Move and codesplit `ProjectPlugins` (#13952) feat(typescript): Add TypeScript compatibility (#13786) ref(templates): Remove unused content block default (#14090) ref(less): Remove unused admin.less (#14097) ref(onobarding): Remove old onboarding experience (#14066) fix(ui) Fix missing conditions in tag bars (#14063) ref(suspect-commits): Add hook (#14057) ref(frontend): Segment frontend web urls (#14096) feat(suspect-commits): Add analytics events (#14080) feat(servicehooks): Update servicehook URLs (#14093) license: Remove license headers (#14095) ref(templates): Remove unused account_nav (#14091) fix: Disable transaction events in store (#14088) fix(InstallWizard): Fix exception when InstallWizard completed (#14092) ref(admin): Fix thrashing on stat charts (#14094) ...
jan-auer
added a commit
that referenced
this pull request
Jul 24, 2019
* master: (115 commits) feat: Update to JS SDK 5.6.0-beta.1 + 0.10.2 sentry-python (#14116) fix(apm): Whitelist dev.getsentry.net for local development (#14117) test(datasets): Make Sentry use generic test functions in Snuba (#14111) ref(suspect-commits): Add text changes to empty state (#14121) build: Switch to psycopg2-binary feat(api): Add option to fetch Organization details without Pr… (#13925) ref: Remove EventDetails endpoint (#14107) test(ui): Mock the onboarding learn more video (#14108) tests(acceptance): Add tests for resolving issues in Issues Li… (#14069) feat(ui): Add basic templates for Incident Rules in settings (#14112) feat(eventsv2) Add basic transaction list (#14103) ref(environments) Optimize environment queries (#14102) fix(events-v2) Add additional user attributes to the user column (#14101) fix: Don't start pageload transaction (#14115) feat: APM Sentry Frontend (#14027) ref(onboarding): Fix install promprt URL (#14106) fix(app-platform): Allow GET requests for published apps (#14109) feat: Update Group.get_latest_event to use Snuba event (#14039) ref(onboarding): Rename wizardNew -> onboarding (#14104) feat(apm): Update props to address proptype warnings for new transaction attributes (SEN-800) (#14040) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing a published integration in an org that is not the owner of the integration is failing because we no longer have
'GET': ()denoting a public endpoint - which we are using to get the integration feature set:sentry-apps/<sentry_app_slug>/features/Instead of returning
Trueinensure_scoped_permission(this piece) we now returnFalsebecauserequest.access.scopesis empty.This PR adds a quick fix, but we should probably rethink (again) what a 'public' endpoint is and where we are using them.