Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Remove EventDetails endpoint #14107

Merged
merged 1 commit into from
Jul 23, 2019
Merged

ref: Remove EventDetails endpoint #14107

merged 1 commit into from
Jul 23, 2019

Conversation

lynnagara
Copy link
Member

This endpoint isn't documented or used by the Sentry web application.
There are no requests for this endpoint logged in Datadog over any recent
time periods so it should be safe to remove.

@lynnagara
ref: Remove EventDetails endpoint
91a37f0 
This endpoint isn't documented or used by the Sentry web application.
There are no requests for this endpoint logged in Datadog over any recent
time periods so it should be safe to remove.
@lynnagara lynnagara requested review from mattrobenolt, a team and JTCunning July 22, 2019 22:10
JTCunning
JTCunning approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@JTCunning JTCunning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍪
It seems as though a handful of people have attempted to use it, but it just results in a 404.

SELECT DISTINCT status
FROM clicktail.access_log
WHERE (request_uri LIKE '/api/0/events/%') AND (statsd_path = 'api.other')

┌─status─┐
│    404 │
└────────┘

@lynnagara lynnagara merged commit 791177b into master Jul 23, 2019
@lynnagara lynnagara deleted the ref/remove-event-details branch July 23, 2019 18:59
jan-auer added a commit that referenced this pull request Jul 24, 2019
@jan-auer
Merge branch 'master' into ref/relay-config-endpoint
f2e08ef 
* master: (115 commits)
  feat: Update to JS SDK 5.6.0-beta.1 + 0.10.2 sentry-python (#14116)
  fix(apm): Whitelist dev.getsentry.net for local development (#14117)
  test(datasets): Make Sentry use generic test functions in Snuba (#14111)
  ref(suspect-commits): Add text changes to empty state (#14121)
  build: Switch to psycopg2-binary
  feat(api): Add option to fetch Organization details without Pr… (#13925)
  ref: Remove EventDetails endpoint (#14107)
  test(ui): Mock the onboarding learn more video (#14108)
  tests(acceptance): Add tests for resolving issues in Issues Li… (#14069)
  feat(ui): Add basic templates for Incident Rules in settings (#14112)
  feat(eventsv2) Add basic transaction list (#14103)
  ref(environments) Optimize environment queries (#14102)
  fix(events-v2) Add additional user attributes to the user column (#14101)
  fix: Don't start pageload transaction (#14115)
  feat: APM Sentry Frontend (#14027)
  ref(onboarding): Fix install promprt URL (#14106)
  fix(app-platform): Allow GET requests for published apps (#14109)
  feat: Update Group.get_latest_event to use Snuba event (#14039)
  ref(onboarding): Rename wizardNew -> onboarding (#14104)
  feat(apm): Update props to address proptype warnings for new transaction attributes (SEN-800) (#14040)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JTCunning JTCunning JTCunning approved these changes

@mattrobenolt mattrobenolt Awaiting requested review from mattrobenolt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lynnagara @JTCunning