Skip to content

feat(am): Virtual horizontal scrollbar for span view #20084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

feat(am): Virtual horizontal scrollbar for span view #20084

wants to merge 3 commits into from

Conversation

dashed
Copy link
Member

@dashed dashed commented Jul 29, 2020 •
edited
Loading

Work in progress

TODO

  • clean up
  • adjust z-index for span details pane such that the virtual scrollbar is below it
  • adjust colours
  • Update scrollable span bars and virtual scrollbar on minimap update? (might not be necessary)
  • Clamp virtual scrollbar to minimum width
  • Hide virtual scrollbar if there's nothing to scroll. Also collapse reserved space.
  • Idea: transparent scroll hitbox

Kapture 2020-07-29 at 14 59 04

@dashed dashed added the WIP label Jul 29, 2020
@dashed dashed requested a review from a team July 29, 2020 19:04
@dashed dashed self-assigned this Jul 29, 2020
@BYK
Copy link
Member

BYK commented Oct 29, 2020

Closing due to staleness and conflicts.

@BYK BYK closed this Oct 29, 2020
@BYK BYK deleted the apm-virtual-scrollbar branch October 29, 2020 20:24
@dashed dashed mentioned this pull request Dec 7, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@dashed dashed

Labels
WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dashed @BYK