feat(apm): Virtual horizontal scrollbar for span view #22504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmak
approved these changes
Dec 7, 2020
markstory
reviewed
Dec 7, 2020
src/sentry/static/sentry/app/components/events/interfaces/spans/header.tsx
Outdated
Show resolved
Hide resolved
src/sentry/static/sentry/app/components/events/interfaces/spans/header.tsx
Outdated
Show resolved
Hide resolved
src/sentry/static/sentry/app/components/events/interfaces/spans/scrollbarManager.tsx
Outdated
Show resolved
Hide resolved
src/sentry/static/sentry/app/components/events/interfaces/spans/scrollbarManager.tsx
Outdated
Show resolved
Hide resolved
| }; | ||
|
|
||
| registerEventListeners = (spanbar: HTMLDivElement) => { | ||
| spanbar.onscroll = this.handleScroll.bind(this, spanbar); |
There was a problem hiding this comment.
Does this need to be throttled or debounced to prevent jank? Should this be using attachEventListener() instead of the DOM1 interface?
There was a problem hiding this comment.
It's already throttled since requestAnimationFrame is used within this.handleScroll. Referenced here https://developer.mozilla.org/en-US/docs/Web/API/Document/scroll_event
I didn't use attachEventListener(), as that'll increase the complexity of having to track references of the attached event listeners. DOM0 event handlers can still be useful despite its age.
src/sentry/static/sentry/app/components/events/interfaces/spans/spanBar.tsx
Outdated
Show resolved
Hide resolved
…s/header.tsx Co-authored-by: Mark Story <mark@sentry.io>
…s/scrollbarManager.tsx Co-authored-by: Mark Story <mark@sentry.io>
dashed
force-pushed
the
span-view-virtual-scrollbar
branch
from
c6f3aad to
bbc999a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two-pane span view doesn't provide sufficient real estate to allow users to read span descriptions that can be very long, or spans that pyramid aggressively to the right. This PR adds a horizontal scroll to address some of these UX issues.
Continuation from #20084
Horizontal scrollbars:
Measurements are moved to the minimap: