Skip to content

ref(MDC): Update Snuba eventstream and insert endpoints #38877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enochtangg merged 1 commit into from
Sep 19, 2022
Merged

ref(MDC): Update Snuba eventstream and insert endpoints #38877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bin/mock-replay
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ from sentry.replays.testutils import mock_replay


def store_replay(replay):
response = requests.post(settings.SENTRY_SNUBA + "/tests/replays/insert", json=[replay])
response = requests.post(
settings.SENTRY_SNUBA + "/tests/entities/replays/insert", json=[replay]
)
assert response.status_code == 200


Expand Down
6 changes: 3 additions & 3 deletions src/sentry/eventstream/snuba.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,13 +392,13 @@ def _send(

data = (self.EVENT_PROTOCOL_VERSION, _type) + extra_data

dataset = "events"
entity = "events"
if is_transaction_event:
dataset = "transactions"
entity = "transactions"
try:
resp = snuba._snuba_pool.urlopen(
"POST",
f"/tests/{dataset}/eventstream",
f"/tests/{entity}/eventstream",
body=json.dumps(data),
headers={f"X-Sentry-{k}": v for k, v in headers.items()},
)
Expand Down
15 changes: 9 additions & 6 deletions src/sentry/testutils/cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -949,7 +949,7 @@ def wait_for_event_count(self, project_id, total, attempts=2):
def bulk_store_sessions(self, sessions):
assert (
requests.post(
settings.SENTRY_SNUBA + "/tests/sessions/insert", data=json.dumps(sessions)
settings.SENTRY_SNUBA + "/tests/entities/sessions/insert", data=json.dumps(sessions)
).status_code
== 200
)
Expand Down Expand Up @@ -988,7 +988,8 @@ def store_group(self, group):
data = [self.__wrap_group(group)]
assert (
requests.post(
settings.SENTRY_SNUBA + "/tests/groupedmessage/insert", data=json.dumps(data)
settings.SENTRY_SNUBA + "/tests/entities/groupedmessage/insert",
data=json.dumps(data),
).status_code
== 200
)
Expand All @@ -997,7 +998,7 @@ def store_outcome(self, group):
data = [self.__wrap_group(group)]
assert (
requests.post(
settings.SENTRY_SNUBA + "/tests/outcomes/insert", data=json.dumps(data)
settings.SENTRY_SNUBA + "/tests/entities/outcomes/insert", data=json.dumps(data)
).status_code
== 200
)
Expand Down Expand Up @@ -1065,7 +1066,7 @@ def snuba_insert(self, events):

assert (
requests.post(
settings.SENTRY_SNUBA + "/tests/events/insert", data=json.dumps(events)
settings.SENTRY_SNUBA + "/tests/entities/events/insert", data=json.dumps(events)
).status_code
== 200
)
Expand Down Expand Up @@ -1337,7 +1338,7 @@ def store_outcomes(self, outcome, num_times=1):

assert (
requests.post(
settings.SENTRY_SNUBA + "/tests/outcomes/insert", data=json.dumps(outcomes)
settings.SENTRY_SNUBA + "/tests/entities/outcomes/insert", data=json.dumps(outcomes)
).status_code
== 200
)
Expand All @@ -1351,7 +1352,9 @@ def setUp(self):
assert requests.post(settings.SENTRY_SNUBA + "/tests/replays/drop").status_code == 200

def store_replays(self, replay):
response = requests.post(settings.SENTRY_SNUBA + "/tests/replays/insert", json=[replay])
response = requests.post(
settings.SENTRY_SNUBA + "/tests/entities/replays/insert", json=[replay]
)
assert response.status_code == 200


Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/test_project_settings_sampling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def store_outcomes(self, outcome, num_times=1):

assert (
requests.post(
settings.SENTRY_SNUBA + "/tests/outcomes/insert", data=json.dumps(outcomes)
settings.SENTRY_SNUBA + "/tests/entities/outcomes/insert", data=json.dumps(outcomes)
).status_code
== 200
)
Expand Down