ref(MDC): Update Snuba eventstream and insert endpoints #38877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Member
|
This is going to break all the sentry tests |
Contributor
Author
This is why this PR should not be merged before: getsentry/snuba#3142. That change supports both the old and new endpoints for eventstream and insert tests. Plan:
|
enochtangg
force-pushed
the
update_evenstream_endpoint
branch
from
fe00596 to
28c619f
Compare
enochtangg
changed the title
enochtangg
force-pushed
the
update_evenstream_endpoint
branch
from
28c619f to
21015ce
Compare
enochtangg
force-pushed
the
update_evenstream_endpoint
branch
from
21015ce to
ca317f2
Compare
enochtangg
force-pushed
the
update_evenstream_endpoint
branch
from
2987e2b to
ca317f2
Compare
enochtangg
force-pushed
the
update_evenstream_endpoint
branch
from
ca317f2 to
a92fc50
Compare
volokluev
approved these changes
Sep 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is responsible for updating the Snuba eventstream and insert test endpoints
POST /tests/{dataset}/eventstreamTo:POST /tests/{entity}/eventstreamPOST /tests/{dataset}/insertTo:POST /tests/entities/{entity}/insertThis change is required due to the removal of the
default_entityattribute in the Dataset class in Snuba. As a result, every request sent to Snuba (e.g. query, eventstream, etc.) must specify both a dataset and entity.The changes to the server endpoint is specified here: getsentry/snuba#3142