fix(snuba): Deprecate un-used routes after removing default_entity from Dataset #3157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volokluev
approved these changes
Sep 19, 2022
JoshFerge
added a commit
to getsentry/sentry
that referenced
this pull request
Sep 19, 2022
fixes broken acceptance test after merge of getsentry/snuba#3157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is responsible for removing un-used routes in Snuba API. After removing
default_entity, the/insertand/eventstreamroutes were updated to acceptEntityas opposed to deriving the entity from dataset.Original changes to endpoints: #3142
Changes to Sentry tests to use new endpoints: getsentry/sentry#38877