ref(hybrid-cloud): use organization_slug in SharedGroupDetails #42792
Conversation
github-actions
bot
added
the
Scope: Backend
src/sentry/api/urls.py
Outdated
| @@ -2334,6 +2334,11 @@ | |||
| SharedGroupDetailsEndpoint.as_view(), | |||
| name="sentry-api-0-shared-group-details", | |||
| ), | |||
| url( | |||
| r"^shared/(?P<organization_slug>[^\/]+)/(?:issues|groups)/(?P<share_id>[^\/]+)/$", | |||
There was a problem hiding this comment.
I'm a little concerned about placing the organization slug at various places inside the URL structure, rather than following the "REST-ful noun" pattern of organizations/(?P<organization_slug>[^\/]+) at the beginning. (I'm not sure how many other mappings are already doing this -- I noticed at least one, after I'd already hit "approve" on it the other day.)
In general, it seems like it's inviting ambiguity. In this case, it looks like we'd be relying on not having an org with "issues" or "groups" as its slug (I don't know if those words are already included in reserved slugs).
When adding org slugs to mappings, would it be plausible to just always follow the pattern of "organizations/ + org slug + old mapping"? Or am I assuming too much?
There was a problem hiding this comment.
it should definitely be possible... i can follow up this PR with another one to modify the ones i've already changed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| r"^issues/(?P<organization_slug>[^\/]+)/(?P<issue_id>[^\/]+)/participants/$", | ||
| r"^organizations/(?P<organization_slug>[^\/]+)/issues/(?P<issue_id>[^\/]+)/participants/$", |
There was a problem hiding this comment.
Do we need the old URL for participants?
There was a problem hiding this comment.
i'm keeping it for now since it's getting some occasional hits
Adds organization_slug to the url for the SharedGroupDetails endpoint. Keeps the original orgless URL for now.
Also fixes the GroupParticipants url with organization_slug to have the
/organizations/{organization_slug}/... formatFor HC-516