ref(hybrid-cloud): fix monitor urls using organization_slug #42825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
will this break the current monitors API? and would our docs and cli have to be updated? |
|
@JoshFerge i had previously changed the urls and then changed what was being used on the frontend without a problem -- this is like a second pass to correct what i had missed the first time (changing the slugs #42300 #42356 #42384, changing the frontend #42728) docs and cli may need to be updated though |
|
@cathyteng17 kk. will defer to @davidenwang |
davidenwang
approved these changes
Jan 5, 2023
| ), | ||
| ), | ||
| url( | ||
| r"^organizations/(?P<organization_slug>[^\/]+)/monitors/", |
There was a problem hiding this comment.
placement of these seems fine for now since its close to the original monitors urls, but could you add a note here that when we delete the old monitors routes that we should probably include these routes into the larger /organizations/ route tree below?
RyanSkonnord
approved these changes
Jan 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format of the url should be
/api/0/organization/{organization_slug}/monitors/...For HC-512, HC-513, HC-514