ensure creation of project team many to many when updating projects #6772
Conversation
Generated by 🚫 danger |
|
travis is mad |
| project.platform = result['platform'] | ||
| changed = True | ||
|
|
||
| if changed: |
There was a problem hiding this comment.
coverage doesn't seem happy about either of these branches, might be worthwhile?
There was a problem hiding this comment.
mm now it says 100% of diff hit, so i think it's ok?
There was a problem hiding this comment.
Can we just use project.team_id instead of fully resolving project.team ? It seems not necessary since you can just use the team id in the query below.
src/sentry/web/forms/add_project.py
Outdated
There was a problem hiding this comment.
Why is this being deleted? Seems unrelated.
There was a problem hiding this comment.
both of these were places that i missed where i needed to create the ProjectTeam relation, but in this case, the AddProjectForm doesn't actually seem to be used anywhere anymore so figured i'd just remove rather than editing
There was a problem hiding this comment.
yeah it was removed here d95c3eb#diff-615ecf8b7cfbfd9bf1f80ed28814ce6bL9
macqueen
force-pushed
the
fix-project-team-create
branch
from
254ec7b to
0ccb917
Compare
part of moving project/team relation to many to many: