Skip to content

ensure creation of project team many to many when updating projects #6772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macqueen merged 2 commits into from
Dec 19, 2017
Merged

ensure creation of project team many to many when updating projects #6772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70de1e7
ref(projects): Remove unused add project form
Dec 15, 2017
0ccb917
fix(projects): Create many to many relationship when changing a proje…
Dec 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/sentry/api/endpoints/project_details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from sentry.api.serializers.rest_framework import ListField, OriginField
from sentry.models import (
AuditLogEntryEvent, Group, GroupStatus, Project, ProjectBookmark, ProjectStatus,
UserOption, Team,
ProjectTeam, UserOption, Team,
)
from sentry.tasks.deletion import delete_project
from sentry.utils.apidocs import scenario, attach_scenarios
Expand Down Expand Up @@ -242,6 +242,7 @@ def put(self, request, project):
project.name = result['name']
changed = True

old_team_id = None
if result.get('team'):
team_list = [
t for t in Team.objects.get_for_user(
Expand All @@ -257,6 +258,7 @@ def put(self, request, project):
'detail': ['The new team is not found.']
}, status=400
)
old_team_id = project.team_id
project.team = team_list[0]
changed = True

Expand All @@ -266,6 +268,11 @@ def put(self, request, project):

if changed:
Copy link
Contributor

@MaxBittker MaxBittker Dec 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coverage doesn't seem happy about either of these branches, might be worthwhile?

Copy link
Contributor Author

@macqueen macqueen Dec 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mm now it says 100% of diff hit, so i think it's ok?

project.save()
if old_team_id is not None:
ProjectTeam.objects.filter(
project=project,
team_id=old_team_id,
).update(team=project.team)

if result.get('isBookmarked'):
try:
Expand Down
49 changes: 0 additions & 49 deletions src/sentry/web/forms/add_project.py
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions tests/sentry/api/endpoints/test_project_details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ def test_team_changes(self):
assert resp.status_code == 200, resp.content
project = Project.objects.get(id=project.id)
assert project.team == team
assert project.teams.first() == team

def test_team_changes_not_found(self):
project = self.create_project()
Expand Down