fix: SentryInternalClient crashing on some log types. #6777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I agree with @dcramer s comment at the top of the function that these messages should just use the regular pipeline, but I'm not 100% sure what's involved in making that change. |
mattrobenolt
approved these changes
Dec 18, 2017
Contributor
Also, yeah, I'd be down to explore this after to figure this out. Right now, we have a few downsides with current implementation that going through this would be useful. |
Contributor
Author
|
@mattrobenolt thanks. I could ship #6785 instead. LMK if you have any thoughts on that, otherwise I will just merge this in the meantime |
[Log messages from Django](https://docs.djangoproject.com/en/2.0/topics/logging/#django-request) contain a `request` object which is not JSON serializable. The regular Raven `Client` has a pretty bulletproof JSON encoder which handles these objects, but SentryInternalClient didn't use it, so there is an exception thrown further down the stack in `insert_data_to_database` when it comes across these objects. This fix forces the Raven JSON encoding of the event. This is not a very efficient solution, but it is at least simple. Untracked files:
alex-hofsteede
force-pushed
the
alex/internal-client-fix
branch
from
44d424d to
792828f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log messages from Django
contain a
requestobject which is not JSON serializable. The regularRaven
Clienthas a pretty bulletproof JSON encoder which handles theseobjects, but SentryInternalClient didn't use it, so there is an
exception thrown further down the stack in
insert_data_to_databasewhen it comes across these objects. This fix forces the Raven JSON
encoding of the event.
This is not a very efficient solution, but it is at least simple.