ref: Change SentryInternalClient to use regular pipeline

[alex-hofsteede]

Send the event to the StoreApi view so that it goes through all the
regular steps instead of reimplementing them in this Client.

[alex-hofsteede]

The only thing I'm unsure about is where to get this auth key from.

[mitsuhiko]

You can just parse the dsn. There is a function in raven python that does that for you.

[alex-hofsteede]

Hmm, perhaps a dumb question, but which DSN? If I understand correctly, this SentryInternalClient is initialized without a DSN because previously it completely bypassed all the authentication and project selection by calling methods on EventManager directly

[mattrobenolt]

I'd say we make it configurable just like SENTRY_PROJECT which is meant to point to the internal project id. Not sure if we can reliably assume an id of 1 for default out of the box? If not, we can just pick one of the DSNs for this project, which is already the project things are being logged to.

[ghost]

	1 Warning
⚠️	You should update CHANGES due to the size of this PR

Generated by 🚫 danger

[alex-hofsteede]

@mattrobenolt Something like this?

In this case how would we populate this value? just hardcode it in the settings here? or have it be some sort of environment variable?

The other thing I guess is that SENTRY_PROJECT becomes a little redundant if the project ID is encoded in the DSN, but I don't want to go and change all of that.

[mattrobenolt]

Sorry, to be more explicit, I meant, we point to a key ID.

So the code would be something like this:

if settings.SENTRY_PROJECT_KEY is not None:
    key = ProjectKey.objects.get(id=settings.SENTRY_PROJECT_KEY)
else:
    key = ProjectKey.objects.filter(project_id=settings.SENTRY_PROJECT, status=ProjectKeyStatus.ACTIVE, roles=ProjectKey.roles.store)[0]

Then build the DSN from the key and project id. This way it's not required to be set, and we default it to just the first key under this project. (Obviously with some error handling if there aren't any keys).

This way we can now point the key to an explicit one for us internally and things in theory should work just fine on new installs.

These bits can then just be passed into the get_auth_header call below with just key.{public,private}_key. So we can bypass this RemoteConfig.from_string call entirely.

[mattrobenolt]

Might even be worth wrapping this in some cache.

[mattrobenolt]

There's also ProjectKey.get_default(project) that we can probably just use if they don't have an id specified.

[alex-hofsteede]

@mitsuhiko @mattrobenolt this is ready now

[mitsuhiko]

As far as I'm concerned: shyp it